Rename legacy ES mock accessors #70432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
pgayvallet
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
botelastic
bot
added
the
Team:Uptime - DEPRECATED
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
jportner
approved these changes
Jul 1, 2020
Contributor
jportner
left a comment
jportner
left a comment
There was a problem hiding this comment.
Code review only -- Security changes LGTM
alisonelizabeth
approved these changes
Jul 1, 2020
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
ES UI changes LGTM.
alisonelizabeth
approved these changes
Jul 1, 2020
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
ES UI changes LGTM.
clintandrewhall
approved these changes
Jul 2, 2020
Contributor
clintandrewhall
left a comment
clintandrewhall
left a comment
There was a problem hiding this comment.
Seems straight-forward for Canvas.
patrykkopycinski
approved these changes
Jul 6, 2020
nnamdifrankie
approved these changes
Jul 6, 2020
Contributor
💛 Build succeeded, but was flaky
Build metrics
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jul 7, 2020
* rename legacy client mocks * move legacy client mocks to legacy folder * fix usages * adapt new usages * adapt new usages # Conflicts: # x-pack/plugins/security/server/authentication/providers/base.mock.ts # x-pack/plugins/security/server/authentication/providers/saml.test.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 7, 2020
* master: Rename legacy ES mock accessors (elastic#70432) [APM] Adds 'Anomaly detection' settings page to create ML jobs per environment (elastic#70560) Forbid timezones not working in Elasticsearch (elastic#70780)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 7, 2020
…rbac * alerting/consumer-based-rbac: Rename legacy ES mock accessors (elastic#70432) [APM] Adds 'Anomaly detection' settings page to create ML jobs per environment (elastic#70560) Forbid timezones not working in Elasticsearch (elastic#70780) [ML] Adding peak_model_bytes to model size stats type (elastic#70825)
pgayvallet
added a commit
that referenced
this pull request
Jul 7, 2020
* Rename legacy ES mock accessors (#70432) * rename legacy client mocks * move legacy client mocks to legacy folder * fix usages * adapt new usages * adapt new usages # Conflicts: # x-pack/plugins/security/server/authentication/providers/base.mock.ts # x-pack/plugins/security/server/authentication/providers/saml.test.ts * adapt 7.x usages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #35508
Extracted from #69905
Prefix the legacy cluster client mock accessors with
Legacyand adapt all thethingscalls.