WIP Speed up integration tests and fail faster #7024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
changed the title
spalger
force-pushed
the
implement/interBailBehavior
branch
2 times, most recently
from
246c59f to
9e80f03
Compare
spalger
force-pushed
the
implement/interBailBehavior
branch
5 times, most recently
from
7a4e854 to
7ebbfe0
Compare
The `common.log` and `common.debug` API currently accept a single string arguments, which is similar to the console.log API but not complete. This simple change brings updates it to match the API completely, supporting things like multiple arguments and sprintf-style templates.
spalger
force-pushed
the
implement/interBailBehavior
branch
3 times, most recently
from
b09ad2b to
7230045
Compare
spalger
force-pushed
the
implement/interBailBehavior
branch
from
5104c68 to
03ea7db
Compare
|
@spalger Did you stop on this for some reason? Was there another issue or PR for switching to Chrome browser? If not, I could pick this up. The urgency for this just went up this week because of Firefox 47 release. According to SeleniumHQ/selenium#1862 we have to switch from the FirefoxDriver driver to Marionette. I've made some progress towards that, but not working yet. |
|
I don't recall precisely. I can take a look later today but I feel like this was basically ready to go. |
|
jenkins, test it |
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Jun 13, 2016
|
Re-implementing in #7442 |
LeeDr
pushed a commit
that referenced
this pull request
Jun 17, 2016
Re-implement most of PR #7024 switch to Chrome browser
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Re-implement most of PR elastic#7024 switch to Chrome browser Former-commit-id: e2ff6bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to use chrome for the integration tests, which has proven to give much better performance rendering Kibana.
It also turns on the new bail option available in version 3.1 of intern. This option will skip any test after a failed one.
Both of these changes are intended to improve performance of the integration tests since they are currently taking close to 15 minutes to run.