[APM] Use licensing from context #70118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added the usage of `featureUsage.notifyUsage` from the licensing plugin in elastic#69455. This required us to use `getStartServices to add `licensing` to `context.plugins`. In elastic#69838 `featureUsage` was added to `context.licensing`, so we don't need to add it to `context.plugins`.
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
smith
added
release_note:skip
ogupte
approved these changes
Jun 26, 2020
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Jun 29, 2020
* [APM] Use licensing from context We added the usage of `featureUsage.notifyUsage` from the licensing plugin in elastic#69455. This required us to use `getStartServices to add `licensing` to `context.plugins`. In elastic#69838 `featureUsage` was added to `context.licensing`, so we don't need to add it to `context.plugins`.
smith
added a commit
that referenced
this pull request
Jun 29, 2020
* [APM] Use licensing from context We added the usage of `featureUsage.notifyUsage` from the licensing plugin in #69455. This required us to use `getStartServices to add `licensing` to `context.plugins`. In #69838 `featureUsage` was added to `context.licensing`, so we don't need to add it to `context.plugins`.
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
Jul 1, 2020
* [APM] Use licensing from context We added the usage of `featureUsage.notifyUsage` from the licensing plugin in elastic#69455. This required us to use `getStartServices to add `licensing` to `context.plugins`. In elastic#69838 `featureUsage` was added to `context.licensing`, so we don't need to add it to `context.plugins`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the usage of
featureUsage.notifyUsagefrom the licensing plugin in #69455.This required us to use
getStartServices to addlicensingtocontext.plugins`.In #69838
featureUsagewas added tocontext.licensing, so we don't need to add it tocontext.plugins.