[Ingest Manager] Improve agent unenrollment with unenroll action #70031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
v7.9.0
Team:Fleet
6 tasks
nchaulet
force-pushed
the
feature-gracefull-unenrollment
branch
from
6d55f54 to
06579cd
Compare
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
Contributor
|
Not a draft: Ready for tests again? |
nchaulet
added
the
release_note:skip
Member
Author
|
@michalpristas yes ready to test again :) |
jfsiii
approved these changes
Jul 2, 2020
Contributor
jfsiii
left a comment
jfsiii
left a comment
There was a problem hiding this comment.
Code and tests LGTM. 👍 once CI is green
| } | ||
| }, | ||
| "/fleet/agents/unenroll": { | ||
| "/fleet/agents/{agentId}/unenroll": { |
They were added to `AgentBase` in the TS so they end up in `Agent`. Committing directly since I couldn't add a suggestion and a PR seemed heavy. Revert/delete if there's any problem.
nnamdifrankie
approved these changes
Jul 2, 2020
jen-huang
reviewed
Jul 3, 2020
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
Contributor
|
Tested OK, |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 3, 2020
* master: (199 commits) [Telemetry] Add documentation about Application Usage (elastic#70624) [Ingest Manager] Improve agent unenrollment with unenroll action (elastic#70031) Handle timeouts on creating templates (elastic#70635) [Lens] Add ability to set colors for y-axis series (elastic#70311) [Uptime] Use elastic charts donut (elastic#70364) [Ingest Manager] Update registry URL to point to snapshot registry (elastic#70687) [Composable template] Create / Edit wizard (elastic#70220) [APM] Optimize services overview (elastic#69648) [Ingest Pipelines] Load from json (elastic#70297) [Rum Dashbaord] Rum selected service view (elastic#70579) [Uptime] Prevent duplicate requests on load for index status (elastic#70585) [ML] Changing shared module setup function parameters (elastic#70589) [Ingest Manager] Add ability to sort to agent configs and package configs (elastic#70676) [Alerting] document requirements for developing new action types (elastic#69164) Fixed adding an extra space character on selecting alert variable in action text fields (elastic#70028) [Maps] show vector tile labels on top (elastic#69444) chore(NA): upgrade to lodash@4 (elastic#69868) Add Snapshot Restore README with quick-testing steps. (elastic#70494) [EPM] Use higher priority than default templates (elastic#70640) [Maps] Fix cannot select Solid fill-color when removing fields (elastic#70621) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 3, 2020
* master: [Lens] Fitting functions (elastic#69820) [Telemetry] Add documentation about Application Usage (elastic#70624) [Ingest Manager] Improve agent unenrollment with unenroll action (elastic#70031) Handle timeouts on creating templates (elastic#70635) [Lens] Add ability to set colors for y-axis series (elastic#70311) [Uptime] Use elastic charts donut (elastic#70364) [Ingest Manager] Update registry URL to point to snapshot registry (elastic#70687) [Composable template] Create / Edit wizard (elastic#70220) [APM] Optimize services overview (elastic#69648)
nchaulet
added a commit
that referenced
this pull request
Jul 6, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #67409
Change the unemrollment flow to let the time for agent to gracefully terminate.
Introduce a new agent action
UNENROLL.The endpoint to unenroll now accept a
force: booleanto unenroll an agent with a gracefull unenrollment or an immediate one.Agent unenrollment:
POST /agents/{agentId}/unenroll-> create anUNENROLLactionUNENROLLaction -> fleet invalidate all the agent API keys.as discussed with @ruflin If an error occurs during unenrollment user will need to call fleet APIs
UI Changes
How to test this
You can use this branch to build a compatible agent elastic/beats#19507
Or you can manually do the API requests to enroll/checkin/ack an agent