Remove injected vars from maps legacy #69744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2020 13:35
… functions through contract
kindsun
added
Feature:Coordinate Map
Feature:Region Map
Team:Geo
…ars-from-maps-legacy
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
kindsun
added
the
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
flash1293
approved these changes
Jun 25, 2020
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Kibana app changes LGTM, code review only
Contributor
|
@elasticmachine merge upstream |
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
The layer drop-down in the coordinate-maps visualization seems empty?
Clicking doesn't show the road_map option either.
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
Contributor
Author
This bug exists on master as well so not related to this PR. Issue created: #70374 |
thomasneirynck
approved these changes
Jul 1, 2020
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
thx for double checking, and logging issue. +1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #69372.
This PR:
getInjectedVarusage frommaps_legacy. It was previously used for two reasons: to get the kibana version and to access theemsTileLayerId. Both of these are obtained via theinitializerContextnow.maps_legacypluginsetupcontract. This was necessary in order for theinitializerContextvalues to populate correctly. It's also ideally how we want to do this and works fine since the changes made in how leaflet is imported were made for Migrate Coordinate Maps to NP #64668