Skip to content

delete testbed plugins #69661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 25, 2020
Merged

delete testbed plugins #69661

merged 3 commits into from
Jun 25, 2020

Conversation

@pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Jun 23, 2020 •
edited
Loading

Summary

Fix #69660

Delete both the legacy and KP testbed plugins.

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.9.0 v8.0.0 labels Jun 23, 2020
pgayvallet
pgayvallet commented Jun 23, 2020
View reviewed changes
test/api_integration/apis/core/index.js
Comment on lines -25 to -36
describe('request context', () => {
it('provides access to elasticsearch', async () =>
await supertest.get('/requestcontext/elasticsearch').expect(200, 'Elasticsearch: true'));

it('provides access to SavedObjects client', async () =>
await supertest
.get('/requestcontext/savedobjectsclient')
.expect(
200,
'SavedObjects client: {"page":1,"per_page":20,"total":0,"saved_objects":[]}'
));
});
Copy link
Contributor Author

@pgayvallet pgayvallet Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, these two tests are based on endpoints that were living in the KP testbed plugin.

I just removed them as I didn't feel like they were adding much value now that most of the plugins have been migrated and using the ES and SO clients from the context.

If we prefer, I can create a test plugin with the testbed's endpoints instead.

@pgayvallet pgayvallet marked this pull request as ready for review June 23, 2020 17:58
@pgayvallet pgayvallet requested a review from a team as a code owner June 23, 2020 17:58
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 23, 2020

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet pgayvallet requested a review from a team June 24, 2020 06:20
mistic
mistic approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 25, 2020

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / kibana-oss-agent / Plugin Functional Tests.test/plugin_functional/test_suites/core_plugins/logging·ts.core plugins plugin logging writes info_json context to custom JSON appender

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:01:20]         └-: core plugins
[00:01:20]           └-> "before all" hook
[00:03:50]           └-: plugin logging
[00:03:50]             └-> "before all" hook
[00:03:50]             └-> does not write to custom appenders when not configured
[00:03:50]               └-> "before each" hook: global before each
[00:03:50]               └-> "before each" hook
[00:03:51]               │ proc [kibana]   log   [13:16:58.287] [info][core_logging][debug_json][plugins] i go to the default appender!
[00:03:51]               └- ✓ pass  (46ms) "core plugins plugin logging does not write to custom appenders when not configured"
[00:03:51]             └-> writes debug_json context to custom JSON appender
[00:03:51]               └-> "before each" hook: global before each
[00:03:51]               └-> "before each" hook
[00:03:51]               └- ✓ pass  (41ms) "core plugins plugin logging writes debug_json context to custom JSON appender"
[00:03:51]             └-> writes info_json context to custom JSON appender
[00:03:51]               └-> "before each" hook: global before each
[00:03:51]               └-> "before each" hook
[00:03:51]               │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/core plugins plugin logging writes info_json context to custom JSON appender.png"
[00:03:51]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2495:20 "App [dev_tools] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:51]               │ debg browser[INFO] http://localhost:6121/9007199254740991/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-06-25T13:16:58Z
[00:03:51]               │        Adding connection to http://localhost:6121/elasticsearch
[00:03:51]               │
[00:03:51]               │      "
[00:03:51]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2495:20 "App [management] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:51]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2495:20 "App [rendering] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:51]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2495:20 "App [custom-app-route] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:51]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2495:20 "App [chromeless] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:51]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2495:20 "App [appleave1] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:51]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2495:20 "App [appleave2] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:51]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2495:20 "App [foo] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:51]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2495:20 "App [bar] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:51]               │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 950:16 "Reporting user-agent."
[00:03:51]               │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 950:16 "Reporting application changed to core_legacy_compat"
[00:03:51]               │ info Current URL is: http://localhost:6121/app/core_legacy_compat
[00:03:52]               │ info Saving page source to: /dev/shm/workspace/kibana/test/plugin_functional/failure_debug/html/core plugins plugin logging writes info_json context to custom JSON appender.html
[00:03:52]               └- ✖ fail: "core plugins plugin logging writes info_json context to custom JSON appender"
[00:03:52]               │

Stack Trace

{ Error: expected [] to sort of equal [ { level: 'INFO',
    context: 'plugins.core_logging.info_json',
    message: 'log2' } ]
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (packages/kbn-expect/expect.js:244:8)
    at Context.it (test/plugin_functional/test_suites/core_plugins/logging.ts:96:40)
  actual: '[]',
  expected:
   '[\n  {\n    "context": "plugins.core_logging.info_json"\n    "level": "INFO"\n    "message": "log2"\n  }\n]',
  showDiff: true }

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit e044940 into elastic:master Jun 25, 2020
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Jun 25, 2020
@pgayvallet
delete testbed plugins (elastic#69661)
5a5e314 
* delete testbed plugins

* remove FTR tests based on KP testbed
@pgayvallet pgayvallet mentioned this pull request Jun 25, 2020
Merged
pgayvallet added a commit that referenced this pull request Jun 25, 2020
@pgayvallet
delete testbed plugins (#69661) (#69990)
b408a9f 
* delete testbed plugins

* remove FTR tests based on KP testbed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mistic mistic mistic approved these changes

+2 more reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@mshustov mshustov mshustov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Delete the testbed plugins

6 participants

@pgayvallet @elasticmachine @kibanamachine @tylersmalley @mshustov @mistic