Skip to content

Disabled multiple select for preconfigured connectors to avoid requesting bulk delete on them #69459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Disabled multiple select for preconfigured connectors to avoid requesting bulk delete on them #69459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2e958a
Disabled multiple select for preconfigured connectors to avoid reques…
YulNaumenko Jun 17, 2020
5578578
Merge remote-tracking branch 'upstream/master' into alerting-ui-disab…
YulNaumenko Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ublic/application/sections/actions_connectors_list/components/actions_connectors_list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ export const ActionsConnectorsList: React.FunctionComponent = () => {
onSelectionChange(updatedSelectedItemsList: ActionConnectorTableItem[]) {
setSelectedItems(updatedSelectedItemsList);
},
selectable: ({ isPreconfigured }: ActionConnectorTableItem) => !isPreconfigured,
}
: undefined
}
Expand Down
3 changes: 3 additions & 0 deletions x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

expect(await testSubjects.exists('deleteConnector')).to.be(false);
expect(await testSubjects.exists('preConfiguredTitleMessage')).to.be(true);

const checkboxSelectRow = await testSubjects.find('checkboxSelectRow-my-server-log');
expect(await checkboxSelectRow.getAttribute('disabled')).to.be('true');
});

it('should not be able to edit a preconfigured connector', async () => {
Expand Down