Skip to content

[7.x] Drilldown docs 2 (#69375) #69410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

[7.x] Drilldown docs 2 (#69375) #69410

merged 1 commit into from
Jun 17, 2020

Conversation

@streamich
Copy link
Contributor

@streamich streamich commented Jun 17, 2020

Backports the following commits to 7.x:

@streamich
Drilldown docs 2 (#69375)
9e2f730 
* docs: ✏️ add drilldown user docs link to REAMDE

* feat: 🎸 wire drilldown docs link into <HelloBar> component

* feat: 🎸 set new page attributes on drilldown docs link

* feat: 🎸 add external prop to link to show icon

* fix: 🐛 remove rel= attribute

* fix: 🐛 add TypeScript type for drilldown docLink
@streamich streamich added the backport This PR is a backport of another PR label Jun 17, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 17, 2020

💚 Build Succeeded

Build metrics

page load asset size

beta
id value diff baseline
/bundles/core/core.entry.js 1.1MB +117.0B 1.1MB
/bundles/plugin/drilldowns/drilldowns.plugin.js 42.2KB +222.0B 42.0KB
total - +339.0B -

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit c822d9e into elastic:7.x Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@streamich @kibanamachine