[SIEM][Timeline][skip-ci] Improve timeline's type

[cnasikas]

Summary

This PR improves the TimelineById type. Specifically, the type allowed any string as a key for the object. The PR limits the keys to only the allowed timeline ids and specifically to the ids that were introduced by #67156

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[kibanamachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: bdfed38
• Pipeline Steps (look for red circles / failed steps)
• Interpreting CI Failures

Failed CI Steps

• Build X-Pack Kibana
• Execute x-pack-intake
• Execute kibana-intake

---

Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/security_solution/public/timelines/store/timeline.Timeline #add saved object Timeline to store should return a timelineModel with default value and not just a timelineResult

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toEqual(expected) // deep equality

- Expected
+ Received

@@ -1,7 +1,7 @@
  Object {
-   "foo": Object {
+   "test": Object {
      "columns": Array [],
      "dataProviders": Array [
        Object {
          "and": Array [],
          "enabled": true,
    at Object.test (/dev/shm/workspace/kibana/x-pack/plugins/security_solution/public/timelines/store/timeline/reducer.test.ts:127:22)
    at Object.asyncJestTest (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
    at new Promise (<anonymous>)
    at mapper (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at promise.then (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
    at process._tickCallback (internal/process/next_tick.js:68:7)

---

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/security_solution/public/timelines/store/timeline.Timeline #addNewTimeline should add a new timeline

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toEqual(expected) // deep equality

- Expected
+ Received

@@ -1,7 +1,7 @@
  Object {
-   "bar": Object {
+   "test": Object {
      "columns": Array [
        Object {
          "columnHeaderType": "not-filtered",
          "id": "@timestamp",
          "width": 190,
@@ -52,11 +52,11 @@
      "eventIdToNoteIds": Object {},
      "eventType": "all",
      "filters": Array [],
      "highlightedDropAndProviderId": "",
      "historyIds": Array [],
-     "id": "bar",
+     "id": "test",
      "isFavorite": false,
      "isLive": false,
      "isLoading": false,
      "isSaving": false,
      "isSelectAllChecked": false,
@@ -84,74 +84,10 @@
      "sort": Object {
        "columnId": "@timestamp",
        "sortDirection": "desc",
      },
      "status": "draft",
-     "templateTimelineId": null,
-     "templateTimelineVersion": null,
-     "timelineType": "default",
-     "title": "",
-     "version": null,
-     "width": 1100,
-   },
-   "foo": Object {
-     "columns": Array [],
-     "dataProviders": Array [
-       Object {
-         "and": Array [],
-         "enabled": true,
-         "excluded": false,
-         "id": "123",
-         "kqlQuery": "",
-         "name": "data provider 1",
-         "queryMatch": Object {
-           "field": "",
-           "operator": ":",
-           "value": "",
-         },
-       },
-     ],
-     "dateRange": Object {
-       "end": 0,
-       "start": 0,
-     },
-     "deletedEventIds": Array [],
-     "description": "",
-     "eventIdToNoteIds": Object {},
-     "highlightedDropAndProviderId": "",
-     "historyIds": Array [],
-     "id": "test",
-     "isFavorite": false,
-     "isLive": false,
-     "isLoading": false,
-     "isSaving": false,
-     "isSelectAllChecked": false,
-     "itemsPerPage": 25,
-     "itemsPerPageOptions": Array [
-       10,
-       25,
-       50,
-     ],
-     "kqlMode": "filter",
-     "kqlQuery": Object {
-       "filterQuery": null,
-       "filterQueryDraft": null,
-     },
-     "loadingEventIds": Array [],
-     "noteIds": Array [],
-     "pinnedEventIds": Object {},
-     "pinnedEventsSaveObject": Object {},
-     "savedObjectId": null,
-     "selectedEventIds": Object {},
-     "show": true,
-     "showCheckboxes": false,
-     "showRowRenderers": true,
-     "sort": Object {
-       "columnId": "@timestamp",
-       "sortDirection": "desc",
-     },
-     "status": "active",
      "templateTimelineId": null,
      "templateTimelineVersion": null,
      "timelineType": "default",
      "title": "",
      "version": null,
    at Object.test (/dev/shm/workspace/kibana/x-pack/plugins/security_solution/public/timelines/store/timeline/reducer.test.ts:154:22)
    at Object.asyncJestTest (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
    at new Promise (<anonymous>)
    at mapper (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at promise.then (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
    at process._tickCallback (internal/process/next_tick.js:68:7)

---

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/security_solution/public/timelines/store/timeline.Timeline #addNewTimeline should add the specified columns to the timeline

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toEqual(expected) // deep equality

- Expected
+ Received

@@ -1,7 +1,7 @@
  Object {
-   "bar": Object {
+   "test": Object {
      "columns": Array [
        Object {
          "aggregatable": true,
          "category": "base",
          "columnHeaderType": "not-filtered",
@@ -131,11 +131,11 @@
      "eventIdToNoteIds": Object {},
      "eventType": "all",
      "filters": Array [],
      "highlightedDropAndProviderId": "",
      "historyIds": Array [],
-     "id": "bar",
+     "id": "test",
      "isFavorite": false,
      "isLive": false,
      "isLoading": false,
      "isSaving": false,
      "isSelectAllChecked": false,
@@ -163,74 +163,10 @@
      "sort": Object {
        "columnId": "@timestamp",
        "sortDirection": "desc",
      },
      "status": "draft",
-     "templateTimelineId": null,
-     "templateTimelineVersion": null,
-     "timelineType": "default",
-     "title": "",
-     "version": null,
-     "width": 1100,
-   },
-   "foo": Object {
-     "columns": Array [],
-     "dataProviders": Array [
-       Object {
-         "and": Array [],
-         "enabled": true,
-         "excluded": false,
-         "id": "123",
-         "kqlQuery": "",
-         "name": "data provider 1",
-         "queryMatch": Object {
-           "field": "",
-           "operator": ":",
-           "value": "",
-         },
-       },
-     ],
-     "dateRange": Object {
-       "end": 0,
-       "start": 0,
-     },
-     "deletedEventIds": Array [],
-     "description": "",
-     "eventIdToNoteIds": Object {},
-     "highlightedDropAndProviderId": "",
-     "historyIds": Array [],
-     "id": "test",
-     "isFavorite": false,
-     "isLive": false,
-     "isLoading": false,
-     "isSaving": false,
-     "isSelectAllChecked": false,
-     "itemsPerPage": 25,
-     "itemsPerPageOptions": Array [
-       10,
-       25,
-       50,
-     ],
-     "kqlMode": "filter",
-     "kqlQuery": Object {
-       "filterQuery": null,
-       "filterQueryDraft": null,
-     },
-     "loadingEventIds": Array [],
-     "noteIds": Array [],
-     "pinnedEventIds": Object {},
-     "pinnedEventsSaveObject": Object {},
-     "savedObjectId": null,
-     "selectedEventIds": Object {},
-     "show": true,
-     "showCheckboxes": false,
-     "showRowRenderers": true,
-     "sort": Object {
-       "columnId": "@timestamp",
-       "sortDirection": "desc",
-     },
-     "status": "active",
      "templateTimelineId": null,
      "templateTimelineVersion": null,
      "timelineType": "default",
      "title": "",
      "version": null,
    at Object.test (/dev/shm/workspace/kibana/x-pack/plugins/security_solution/public/timelines/store/timeline/reducer.test.ts:170:22)
    at Object.asyncJestTest (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
    at new Promise (<anonymous>)
    at mapper (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at promise.then (/dev/shm/workspace/kibana/node_modules/jest-jasmine2/build/queueRunner.js:73:41)
    at process._tickCallback (internal/process/next_tick.js:68:7)

---

and 38 more failures, only showing the first 3.

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream