[Maps] use EuiColorPalettePicker #69190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
chore
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
Contributor
Author
|
blocked by elastic/eui#3615. No way to set data-test-subj so its not possible to select color picker in functional test |
elizabetdev
suggested changes
Jun 17, 2020
Contributor
elizabetdev
left a comment
elizabetdev
left a comment
There was a problem hiding this comment.
It looks good! Just missing an xs gutter size to match the other rows.
| ) : null; | ||
|
|
||
| return ( | ||
| <EuiFlexGroup gutterSize={'none'}> |
Contributor
There was a problem hiding this comment.
Suggested change
| <EuiFlexGroup gutterSize={'none'}> | |
| <EuiFlexGroup gutterSize={'xs'}> |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
retest |
nreese
requested review from
elizabetdev and
kindsun
and removed request for
thomasneirynck
kindsun
reviewed
Jul 13, 2020
x-pack/plugins/maps/public/classes/styles/color_palettes.test.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine merge upstream |
kindsun
approved these changes
Jul 13, 2020
Contributor
kindsun
left a comment
kindsun
left a comment
There was a problem hiding this comment.
Great to have some new colors to work with. Thanks for this! 🌈
lgtm!
- code review
- tested locally in chrome
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
History
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jul 13, 2020
* [Maps] use EuiColorPalettePicker and Eui palettes * use new ramps to create mb style * update ColorMapSelect to use EuiColorPalettePicker * move color_utils test to color_palettes * clean up heatmap constants * tslint * fix test expects * fix merge mistake * update jest expects * remove .chromium folder * another jest expect update * remove charts from kibana.json * remove unneeded jest.mock Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Jul 13, 2020
* [Maps] use EuiColorPalettePicker and Eui palettes * use new ramps to create mb style * update ColorMapSelect to use EuiColorPalettePicker * move color_utils test to color_palettes * clean up heatmap constants * tslint * fix test expects * fix merge mistake * update jest expects * remove .chromium folder * another jest expect update * remove charts from kibana.json * remove unneeded jest.mock Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
src/plugins/charts/publiccolor maps with EUI color palettes.EuiSuperSelectcolor palette picker withEuiColorPalettePickercomponent.Blue to Redpalette.Blue to Redpalette will be useful come fall for making it easy to create election cycle maps.src/plugins/charts/publicStaying up to date with EUI will help ensure consistency between the Maps application and the rest of Kibana