Skip to content

[7.x] Improve Embeddable loading and error handling UI (#68623) #69108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2020
Merged

[7.x] Improve Embeddable loading and error handling UI (#68623) #69108

merged 1 commit into from
Jun 13, 2020

Conversation

@lizozom
Copy link
Contributor

@lizozom lizozom commented Jun 13, 2020

Backports the following commits to 7.x:

@lizozom @elasticmachine
Improve Embeddable loading and error handling UI (elastic#68623)
9bdb6eb 
* Add error label on visualize embeddable error
Gray out loading \ errored results

* Translate label

* code review

* Rename ExpressionRenderError, better scss

* oopsy

* Generalize solution to be used by other embeddables

* Cleanup

* css fix

* Move wrapper div into label component

* Lighten panel title while loading
Integrate with search embeddable

* translations

* Error notification in visualize app

* Update render count on error

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@lizozom lizozom added the backport This PR is a backport of another PR label Jun 13, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 13, 2020

💚 Build Succeeded

Build metrics

page load asset size

beta
id value diff baseline
/bundles/plugin/canvas/canvas.plugin.js 3.4MB +2.9KB 3.4MB
/bundles/plugin/dashboard/dashboard.plugin.js 1.1MB +2.3KB 1.1MB
/bundles/plugin/dashboardEnhanced/dashboardEnhanced.plugin.js 754.2KB +2.3KB 751.9KB
/bundles/plugin/dashboardMode/dashboardMode.plugin.js 1.1MB +2.3KB 1.1MB
/bundles/plugin/data/data.plugin.js 1.7MB +381.0B 1.7MB
/bundles/plugin/discover/discover.plugin.js 762.6KB +2.0KB 760.5KB
/bundles/plugin/drilldowns/drilldowns.plugin.js 726.5KB +2.3KB 724.3KB
/bundles/plugin/embeddable/embeddable.plugin.js 614.7KB +2.3KB 612.4KB
/bundles/plugin/embeddableEnhanced/embeddableEnhanced.plugin.js 714.2KB +2.3KB 712.0KB
/bundles/plugin/expressions/expressions.plugin.js 733.9KB +119.0B 733.8KB
/bundles/plugin/lens/lens.plugin.js 1.9MB +2.9KB 1.9MB
/bundles/plugin/ml/ml.plugin.js 2.0MB +2.3KB 2.0MB
/bundles/plugin/reporting/reporting.plugin.js 914.9KB +2.0KB 912.8KB
/bundles/plugin/uiActionsEnhanced/uiActionsEnhanced.plugin.js 693.0KB +2.3KB 690.7KB
/bundles/plugin/visualizations/visualizations.plugin.js 985.2KB +2.9KB 982.2KB
total - +31.4KB -

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lizozom lizozom merged commit 22d95a2 into elastic:7.x Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lizozom @kibanamachine