[security_solution] enable react-hooks/exhaustive-deps #68470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable `react-hooks/exhaustive-deps` rule for security_solution * Disable it anywhere that it would catch an issue
oatkiller
commented
Jun 6, 2020
| const abortCtrl = new AbortController(); | ||
|
|
||
| async function fetchData(forceReload: boolean = false) { | ||
| async function fetchData() { |
Contributor
Author
There was a problem hiding this comment.
removing unused parameters
oatkiller
commented
Jun 6, 2020
| fetchData(); | ||
| reFetchRules.current = (refreshPrePackagedRule: boolean = false) => { | ||
| fetchData(true); | ||
| fetchData(); |
Contributor
Author
There was a problem hiding this comment.
removing unused parameters
oatkiller
commented
Jun 6, 2020
| filterOptions.filter, | ||
| filterOptions.sortField, | ||
| filterOptions.sortOrder, | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
Contributor
Author
There was a problem hiding this comment.
Doing a sort on every render is not generally advisable. Even if it happened to be harmless here, when reading this code I feel the urge to confirm that filterOptions.tags is of a constant size.
Might be worth scheduling work to improve. We could probably just wrap it in a useMemo if nothing else.
oatkiller
commented
Jun 6, 2020
| const onSubmit = useCallback(async () => { | ||
| const { isValid, data } = await form.submit(); | ||
| if (isValid) { | ||
| // `postCase`'s type is incorrect, it actually returns a promise |
Contributor
Author
There was a problem hiding this comment.
Is this comment correct? I think we could update the type.
oatkiller
commented
Jun 6, 2020
|
|
||
| const onResizeStop: ResizeCallback = useCallback( | ||
| (e, direction, ref, delta) => { | ||
| (_e, _direction, _ref, delta) => { |
Contributor
Author
There was a problem hiding this comment.
Tell tsserver/tsc to ignore the fact that these are unused
oatkiller
commented
Jun 6, 2020
|
|
||
| /** Invoked when the user clicks the action to delete the selected timelines */ | ||
| const onDeleteSelected: OnDeleteSelected = useCallback(async () => { | ||
| // The type for `deleteTimelines` is incorrect, it returns a Promise |
Contributor
Author
There was a problem hiding this comment.
Is this comment right? We could probably fix the type.
oatkiller
commented
Jun 6, 2020
| endDate, | ||
| skip, | ||
| userPermissions, | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
Contributor
Author
There was a problem hiding this comment.
It might be worth improving this, as sorting something each render could hinder performance.
oatkiller
commented
Jun 6, 2020
|
|
||
| useEffect(() => { | ||
| onSelectedGroupsChanged(selectedGroups); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
Contributor
Author
There was a problem hiding this comment.
Another instance of sorting in render. Thoughts on these?
oatkiller
commented
Jun 6, 2020
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [ | ||
| featureIndex, | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
Contributor
Author
There was a problem hiding this comment.
Another sort in render
oatkiller
added
release_note:skip
2 tasks
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
patrykkopycinski
approved these changes
Jun 8, 2020
oatkiller
pushed a commit
to oatkiller/kibana
that referenced
this pull request
Jun 8, 2020
* Enable `react-hooks/exhaustive-deps` rule for security_solution * Disable it anywhere that it would catch an issue # Conflicts: # x-pack/plugins/security_solution/public/common/components/exceptions/viewer/exception_entries.tsx
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 8, 2020
* master: [ML] DFAnalytics results: ensure ml result fields are shown in data grid (elastic#68305) [security_solution] enable react-hooks/exhaustive-deps (elastic#68470) Closes elastic#66867 by adding missing, requried API params (elastic#68465) [Telemetry] collect number of visualization saved in the past 7, 30 and 90 days (elastic#67865) [Logs UI] View in context tweaks (elastic#67777) Kibana developer examples landing page (elastic#67049) Bump decompress package version (elastic#68386) fix elastic#66185 (elastic#66186) Bump pdfmake package version (elastic#68395) Unskip embeddables/adding_children suite (elastic#68111) Add embed mode options in the Share UI (elastic#58435) Adding key to avoid react warning (elastic#68491)
oatkiller
pushed a commit
that referenced
this pull request
Jun 9, 2020
* Enable `react-hooks/exhaustive-deps` rule for security_solution * Disable it anywhere that it would catch an issue # Conflicts: # x-pack/plugins/security_solution/public/common/components/exceptions/viewer/exception_entries.tsx
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
MindyRS
added
the
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
react-hooks/exhaustive-depsrule for security_solutionChecklist
Delete any items that are not applicable to this PR.
For maintainers