Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] install default packages in parallel #67893

Merged

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented Jun 1, 2020

#66125
In cloud, /setup is taking so long that it times out. We should continue to try and make more optimizations but this was an obvious one.

  • Changes the installation of default packages in setup to be parallel

To test try these changes on master and compare to this branch:

  • Restart elasticsearch so no packages are installed
  • Refresh Kibana in the browser with devtools open and see the /setup request
  • The initial setup requests takes about 9-10 seconds on master and about 6-7 with these changes

Before:
Screen Shot 2020-06-01 at 3 00 13 PM

After:
Screen Shot 2020-06-01 at 2 48 34 PM

Note: In the screenshots, /setup gets gets called twice in Ingest Manager, so the larger number is the one to look at which happens first

@neptunian neptunian added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:alpha1 Group issues for ingest management alpha1 labels Jun 1, 2020
@neptunian neptunian requested review from jfsiii and a team June 1, 2020 19:05
@neptunian neptunian self-assigned this Jun 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

Copy link
Contributor

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't run locally because I'm having environment issues but this looks good to me.

Reducing the time from SUM(A, B, C) to MAX(A, B, C) is a big win

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it work as expected :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingest Management:alpha1 Group issues for ingest management alpha1 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants