[Detection Engine] Update alert apiKey when the rule is updated #67364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykkopycinski
added
bug
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Contributor
Author
|
@elasticmachine merge upstream |
…kkopycinski/kibana into fix/siem-rule-action-apikey-update
…-action-apikey-update
rylnd
approved these changes
May 26, 2020
Contributor
rylnd
left a comment
rylnd
left a comment
There was a problem hiding this comment.
Desk-tested the following scenarios:
- Creating rules with actions (POST)
- Removing a rule's actions (PUT)
- as outlined in the original bug report
- Adding an action to a previously de-actioned rule (PUT)
- Partial update of a rule via the API (PATCH)
All of the above work as expected and have no impact on a rule's execution (nor its actions').
Thanks @patrykkopycinski !
Contributor
Author
|
@elasticmachine merge upstream |
mikecote
approved these changes
May 26, 2020
x-pack/plugins/siem/server/lib/detection_engine/rules/update_rules_notifications.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Mike Côté <mikecote@users.noreply.github.com>
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced May 26, 2020
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 26, 2020
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
May 26, 2020
…tic#67364) # Conflicts: # x-pack/plugins/siem/server/lib/detection_engine/rules/update_rules_notifications.ts
rylnd
pushed a commit
that referenced
this pull request
May 27, 2020
…) (#67426) # Conflicts: # x-pack/plugins/siem/server/lib/detection_engine/rules/update_rules_notifications.ts Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
patrykkopycinski
added a commit
that referenced
this pull request
May 27, 2020
…) (#67425) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
patrykkopycinski
added a commit
that referenced
this pull request
May 27, 2020
…) (#67424) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Closed
3 tasks
MindyRS
added
the
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #64870