[SIEM] [Maps] Fixes Network Map empty tooltip #66828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
spong
commented
May 15, 2020
spong
commented
May 15, 2020
spong
commented
May 15, 2020
...gins/siem/public/network/components/embeddables/map_tool_tip/point_tool_tip_content.test.tsx
Show resolved
Hide resolved
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
dhurley14
reviewed
May 18, 2020
dhurley14
approved these changes
May 18, 2020
Contributor
dhurley14
left a comment
dhurley14
left a comment
There was a problem hiding this comment.
SIEM changes look good
nreese
approved these changes
May 18, 2020
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
maps changes LGTM
code review
spong
added a commit
to spong/kibana
that referenced
this pull request
May 19, 2020
## Summary Resolves elastic#63474, and expands `ITooltipProperty`'s `rawValue` type to include `string[]` as mentioned [here](elastic#61264 (comment)).  ### Checklist Delete any items that are not applicable to this PR. - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
spong
added a commit
that referenced
this pull request
May 19, 2020
## Summary Resolves #63474, and expands `ITooltipProperty`'s `rawValue` type to include `string[]` as mentioned [here](#61264 (comment)).  ### Checklist Delete any items that are not applicable to this PR. - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
spong
added a commit
to spong/kibana
that referenced
this pull request
May 19, 2020
## Summary Resolves elastic#63474, and expands `ITooltipProperty`'s `rawValue` type to include `string[]` as mentioned [here](elastic#61264 (comment)).  ### Checklist Delete any items that are not applicable to this PR. - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios # Conflicts: # x-pack/plugins/maps/public/classes/fields/es_agg_field.ts # x-pack/plugins/maps/public/classes/fields/es_doc_field.ts # x-pack/plugins/maps/public/classes/fields/field.ts # x-pack/plugins/maps/public/classes/tooltips/es_tooltip_property.ts # x-pack/plugins/maps/public/classes/tooltips/join_tooltip_property.ts # x-pack/plugins/maps/public/classes/tooltips/tooltip_property.ts # x-pack/plugins/maps/public/index.ts # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/line_tool_tip_content.tsx # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/map_tool_tip.tsx # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/point_tool_tip_content.test.tsx # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/point_tool_tip_content.tsx # x-pack/plugins/siem/public/network/components/embeddables/types.ts
This was referenced May 19, 2020
spong
added a commit
to spong/kibana
that referenced
this pull request
May 19, 2020
## Summary Resolves elastic#63474, and expands `ITooltipProperty`'s `rawValue` type to include `string[]` as mentioned [here](elastic#61264 (comment)).  ### Checklist Delete any items that are not applicable to this PR. - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios # Conflicts: # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/map_tool_tip.tsx # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/point_tool_tip_content.test.tsx # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/point_tool_tip_content.tsx # x-pack/plugins/siem/public/network/components/embeddables/types.ts
spong
added a commit
that referenced
this pull request
May 19, 2020
## Summary Resolves #63474, and expands `ITooltipProperty`'s `rawValue` type to include `string[]` as mentioned [here](#61264 (comment)).  ### Checklist Delete any items that are not applicable to this PR. - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios # Conflicts: # x-pack/plugins/maps/public/classes/fields/es_agg_field.ts # x-pack/plugins/maps/public/classes/fields/es_doc_field.ts # x-pack/plugins/maps/public/classes/fields/field.ts # x-pack/plugins/maps/public/classes/tooltips/es_tooltip_property.ts # x-pack/plugins/maps/public/classes/tooltips/join_tooltip_property.ts # x-pack/plugins/maps/public/classes/tooltips/tooltip_property.ts # x-pack/plugins/maps/public/index.ts # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/line_tool_tip_content.tsx # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/map_tool_tip.tsx # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/point_tool_tip_content.test.tsx # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/point_tool_tip_content.tsx # x-pack/plugins/siem/public/network/components/embeddables/types.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 19, 2020
* master: (24 commits) [APM] agent config 'profiling_inferred_spans_min_duration' default value is '0ms' but the min value in the field is '1ms' (elastic#66886) [Canvas] Fix flaky custom element functional tests (elastic#65908) Fix IE specific flexbox min-height issue (elastic#66555) [Discover] Unskip doc link functional test (elastic#66884) Index pattern management to Kibana platform (elastic#65026) Warning and link to support matrix for IE11 (elastic#66512) [Reporting] Consolidate Server Type Defs, move some out of Legacy (elastic#66144) [SIEM] [Maps] Fixes Network Map empty tooltip (elastic#66828) [Endpoint] Encode the index of the alert in the id response (elastic#66919) [services/testSubjects] reduce retry usage, add waitForEnabled (elastic#66538) [DOCS] Identifies cloud settings for APM (elastic#66935) [SIEM][CASE] Fix configuration's page user experience (elastic#66029) Resolver: Display node 75% view submenus (elastic#64121) [SIEM] Cases] Capture timeline click and open timeline in case view (elastic#66327) [APM] Lowercase agent names so icons work (elastic#66824) [dev/cli] add support for --no-cache (elastic#66837) [Ingest Manager] Better handling of package installation problems (elastic#66541) [ML] Enhances api docs for modules endpoints (elastic#66738) dont hide errors (elastic#66764) [RFC] Global search API (elastic#64284) ...
spong
added a commit
that referenced
this pull request
May 19, 2020
* [SIEM] [Maps] Fixes Network Map empty tooltip (#66828) ## Summary Resolves #63474, and expands `ITooltipProperty`'s `rawValue` type to include `string[]` as mentioned [here](#61264 (comment)).  ### Checklist Delete any items that are not applicable to this PR. - [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios # Conflicts: # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/map_tool_tip.tsx # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/point_tool_tip_content.test.tsx # x-pack/plugins/siem/public/network/components/embeddables/map_tool_tip/point_tool_tip_content.tsx # x-pack/plugins/siem/public/network/components/embeddables/types.ts * Updating imports... * And another
MindyRS
added
the
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #63474, and expands
ITooltipProperty'srawValuetype to includestring[]as mentioned here.Checklist
Delete any items that are not applicable to this PR.