Skip to content

[7.x] unskip newsfeed tests (#66562) #66734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2020
Merged

[7.x] unskip newsfeed tests (#66562) #66734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/functional/apps/home/_newsfeed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
}
});

// TODO currently fails because styles are not correctly applied in the new platform
it.skip('clicking on newsfeed icon should close opened newsfeed', async () => {
it('clicking on newsfeed icon should close opened newsfeed', async () => {
await globalNav.clickNewsfeed();
const isOpen = await PageObjects.newsfeed.openNewsfeedPanel();
expect(isOpen).to.be(false);
Expand Down
3 changes: 1 addition & 2 deletions test/ui_capabilities/newsfeed_err/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ export default function uiCapabilitiesTests({ getService, getPageObjects }: FtrP
expect(objects).to.eql([]);
});

// TODO currently fails because styles are not correctly applied in the new platform
it.skip('clicking on newsfeed icon should close opened newsfeed', async () => {
it('clicking on newsfeed icon should close opened newsfeed', async () => {
await globalNav.clickNewsfeed();
const isOpen = await PageObjects.newsfeed.openNewsfeedPanel();
expect(isOpen).to.be(false);
Expand Down