Skip to content

Conversation

@shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented May 7, 2020

Summary

Initial issue described in elastic/eui#2393 is no longer reproducible, seems like basic table got refactored so i can't reproduce the issue, so enable loading on monitor list.

Also enabled loading on cert list.

@shahzad31 shahzad31 requested a review from a team as a code owner May 7, 2020 12:17
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label May 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 requested a review from andrewvc May 7, 2020 12:17
@shahzad31 shahzad31 self-assigned this May 7, 2020
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 v8.0.0 labels May 7, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit 8f05cf0 into elastic:master May 8, 2020
@shahzad31 shahzad31 deleted the enable-monitor-list-loading branch May 8, 2020 12:43
@shahzad31 shahzad31 restored the enable-monitor-list-loading branch May 8, 2020 13:49
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 11, 2020
* master: (58 commits)
  [Drilldowns][chore] import dashboard url generator from plugin contract (elastic#64628)
  fix double flyouts in add panel flow (elastic#65861)
  Point 7.x to 7.9.0 in .backportrc.json
  Mount ui/new_platform applications in same div structure as Core (elastic#63930)
  [Uptime] Settings threshold validation (elastic#65454)
  Fix edit alert flyout to update initialAlert after edit (elastic#65359)
  Fix anomalies display on focused APM service map (elastic#65882)
  [SIEM][Detection Engine] Increases the template limit for ECS mappings
  [SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (elastic#65851)
  [Metrics UI] Fix p95/p99 charts and alerting error (elastic#65579)
  [ML] Add job timing stats to anomaly jobs (elastic#65696)
  restore index pattern management data-test-subj's (elastic#64697)
  [Discover] Prevent whitespace wrapping of doc table header (elastic#52861)
  [SIEM] Fixes a CSS issue with Timeline field truncation (elastic#65789)
  Skipping failing tests. elastic#65867 elastic#65866 elastic#65865
  [Discover] Deangularize the hits counter and create a react component (elastic#65631)
  Tsvb less update (elastic#65467)
  [TSVB] Remove remaining lodash.set usage (elastic#65846)
  [Uptime] Add `a11y` tests (elastic#65514)
  [Uptime] Enable loading on monitor list (elastic#65670)
  ...
shahzad31 added a commit to shahzad31/kibana that referenced this pull request May 12, 2020
shahzad31 added a commit to shahzad31/kibana that referenced this pull request May 12, 2020
@shahzad31 shahzad31 deleted the enable-monitor-list-loading branch February 15, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 v7.9.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants