Skip to content

[ML] Consolidating shared types and util functions #65460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[ML] Consolidating shared types and util functions #65460

wants to merge 2 commits into from

Conversation

@jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented May 6, 2020

Moving all constants, types and util functions which are being used by other plugins to a single list exported from the entry point of the ML client side plugin.

A remake of #65247

@jgowdyelastic jgowdyelastic requested review from a team as code owners May 6, 2020 11:48
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label May 6, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented May 6, 2020

Pinging @elastic/uptime (Team:uptime)

@jgowdyelastic jgowdyelastic self-assigned this May 6, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented May 6, 2020

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0 refactoring labels May 6, 2020
peteharverson
peteharverson approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

walterra
walterra approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML/transform changes LGTM

@kibanamachine
Copy link
Contributor

kibanamachine commented May 6, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jgowdyelastic
Copy link
Member Author

jgowdyelastic commented May 7, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented May 7, 2020

user doesn't have permission to update head repository

@jgowdyelastic jgowdyelastic deleted the consolidating-shared-types-and-util-functions-2 branch May 7, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels

Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes refactoring release_note:skip Skip the PR/issue when compiling release notes review Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jgowdyelastic @elasticmachine @kibanamachine @walterra @peteharverson