Disallows commonjs in new platform public #65218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2 tasks
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tylersmalley
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
flash1293
approved these changes
May 5, 2020
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Graph changes LGTM, code review only
chrisronline
approved these changes
May 5, 2020
Contributor
chrisronline
left a comment
chrisronline
left a comment
There was a problem hiding this comment.
LGTM from stack monitoring
cjcenizal
approved these changes
May 5, 2020
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Console code LGTM, tested locally and autocomplete, selective disabling of autocomplete suggestions, and highlighting seems to work as expected.
Contributor
Author
|
Thanks all! |
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
May 5, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
pushed a commit
that referenced
this pull request
May 6, 2020
tylersmalley
pushed a commit
to tylersmalley/kibana
that referenced
this pull request
May 6, 2020
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
pushed a commit
that referenced
this pull request
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite to enabling tree shaking on the new platform
Blocks #62390