Skip to content

Fix issue with navigating in firefox/safari #65163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2020
Merged

Fix issue with navigating in firefox/safari #65163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8204b4
Fix issue with navigating in firefox/safari
timroes May 4, 2020
b7a1c91
Merge branch 'master' into fix/navigation-issues
timroes May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/plugins/visualize/public/application/legacy_app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,19 @@ export function initVisualizeApp(app, deps) {
);
}

// This delay is needed to prevent some navigation issues in Firefox/Safari.
// see https://github.com/elastic/kibana/issues/65161
const delay = res => {
return new Promise(resolve => {
setTimeout(() => resolve(res), 0);
});
};

return data.indexPatterns
.ensureDefaultIndexPattern(history)
.then(() => savedVisualizations.get($route.current.params))
.then(getResolvedResults(deps))
.then(delay)
.catch(
Copy link
Contributor

@wylieconlon wylieconlon May 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: I needed to reread some docs on Chained Promises.

Won't this .catch no longer catch errors from the getResolvedResults function, since the delay function can never throw an error? This looks like it could inadvertently cause our error handling behavior to be different

redirectWhenMissing({
history,
Expand Down