Skip to content

Conversation

@oatkiller
Copy link
Contributor

@oatkiller oatkiller commented May 4, 2020

Summary

  • position nodes w/ just left and top, instead of left, top, and transform.
  • Remove padding on resolver map. the raster size measuring code doesn't account for this.
  • Remove constant (+10) from node position expression. As it's not being multiplied against the projection matrix, it won't scale
  • Remove unused variables

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@oatkiller oatkiller requested review from a team as code owners May 4, 2020 16:33
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@oatkiller oatkiller added Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes v7.8 v8.0.0 labels May 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

left: `${left}px`,
top: `${top}px`,
left: `${left + processNodeViewXOffset}px`,
top: `${top + processNodeViewYOffset}px`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ It seemed a little more intuitive to me to keep the calculated value of left and top for the element aligned with the left and top but I guess it doesn't change anything material about the way it lays out, so if you like this better go for it.

user-select: none;
box-sizing: border-box;
border-radius: 10%;
padding: 4px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ A lot of these style rules were set to meet design's guidance via the mocks and signed off by them. You tested to make certain this doesn't alter what they've signed off on?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, but we can't support having a padding w/o adjusting the logic that measures the size of the resolver map.

@tylersmalley tylersmalley added v7.8.0 and removed v7.8 labels May 5, 2020
@oatkiller oatkiller merged commit 4571536 into elastic:master May 6, 2020
@oatkiller oatkiller deleted the resolver-remove-transform branch May 6, 2020 13:41
oatkiller pushed a commit to oatkiller/kibana that referenced this pull request May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants