Remove redundant formatting of percentage column #64948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-30-fix-data-table-rounding
kertal
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
myasonik
approved these changes
May 5, 2020
Contributor
myasonik
left a comment
myasonik
left a comment
There was a problem hiding this comment.
LGTM!
Tested in FF locally as well
Contributor
|
Do you think this also fixes #64621 ? It seems like a similar issue |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
May 6, 2020
* Remove redundant formatting of percentage column * Fix functional test * Fix browser test
kertal
added a commit
that referenced
this pull request
May 6, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 6, 2020
* master: (72 commits) add tsvb tests to Firefox suite (elastic#65425) Fix flaky ServerMetricsCollector integration test (elastic#65420) [APM] Custom links section inside the Actions menu is showing outside of the menu (elastic#65428) [ML] Adds docs_per_second to transform edit form. (elastic#65365) update apm index pattern (elastic#65424) add direct build command (elastic#65431) [ML] Adding daily_model_snapshot_retention_after_days to types and schemas (elastic#65417) [chore] Improve request cancelation handling in vis embeddable (elastic#65057) [Alerting] migrates acceptance and functional test fixtures to KP (elastic#64888) [ML] Fixes reordering in view by selection when overall cell selected (elastic#65290) Additional branding updates (elastic#64712) Remove redundant formatting of percentage column (elastic#64948) [SIEM][CASE] Configuration pages UI redesign (elastic#65355) New nav (elastic#64018) [Ingest pipelines] Address copy feedback (elastic#65175) bug fixing (elastic#65387) skip whole suite blocking snapshots (elastic#65377) add related event generation to ancestor nodes (fixes a bug) (elastic#64950) [Canvas] move files from legacy/plugins to plugins (elastic#65283) [SIEM] template timeline UI (elastic#64439) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #64939
Fixes #64621
Fixes an issue with Count percentage value rounding in Visualize Data Table. When using the default setting of
format:percent:defaultPattern:The Count percentage of products priced >= 0 ands < 11 in this example was displayed 14.8% instead of 14.771
The reason for this was that the number was formatted and rounded twice.
Checklist
Delete any items that are not applicable to this PR.