[Canvas] Finish moving UI to Kibana Platform #64831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crob611
added
review
Feature:New Platform
Team:Presentation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
Contributor
Author
|
@joshdover In case you want to play around and try and see how you can break this |
Contributor
You can also use SIEM, Metrics, Logs, ML |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
This seems to have the same problem that Monitoring had here: #62908 (comment) Basically you need to make sure that clicking the "Canvas" icon in the main nav always navigates back to the root of your application. |
poffdeluxe
approved these changes
Apr 30, 2020
Contributor
poffdeluxe
left a comment
poffdeluxe
left a comment
There was a problem hiding this comment.
lgtm -- just one question about the nav link route changing stuff
| connect(mapStateToProps, mapDispatchToProps, mergeProps), | ||
| withProps(() => ({ | ||
| onRouteChange: trackRouteChange, | ||
| onRouteChange: () => undefined, |
Contributor
There was a problem hiding this comment.
Can this just be removed? Are we tracking nav links still?
crob611
added
release_note:breaking
and removed
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
ryankeairns
approved these changes
May 4, 2020
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
May 4, 2020
* Finish Canvas platform migration * Revert inadvertent change * Import Canvas .scss directly Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
crob611
pushed a commit
that referenced
this pull request
May 5, 2020
* Finish Canvas platform migration * Revert inadvertent change * Import Canvas .scss directly Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gchaps
added
release_note:plugin_api_changes
Contributor
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / kibana-intake-agent / Jest Integration Tests.packages/kbn-es/src/integration_tests.#start(installPath) resolves when bin/elasticsearch logs "started"Standard OutStack TraceKibana Pipeline / kibana-intake-agent / Jest Integration Tests.src/core/server/http/integration_tests.http service elasticsearch passes request authorization header to Elasticsearch if registerAuth was not setStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes moving the UI of Canvas to Kibana Platform 🎉
Key changes here that differ from running on legacy are cleaning up the store and the router and the history object when our app is "finished".
Also a couple of imports where we had to pull in specific dist versions as something with the module the new optimizer was not liking.
There are a handful of other things running on the platform right now, I'm just not sure which ones they are. You can run Kibana with the option
yarn start --plugin-path test/plugin_functional/plugins/core_plugin_aand it will add aFooplugin so you can see switching back and forth between apps.Dev Docs
The Canvas application has moved to run on the new Kibana Platform.
Any existing user created plugins that were extending Canvas functionality will also need to move to run on the Kibana Platform to continue extending Canvas.