[ngSanitize] add explicit dependencies to all uses of ngSanitize angular module
#64546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…requirement-for-ngSanitize
…requirement-for-ngSanitize
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
spalger
added
release_note:skip
igoristic
reviewed
Apr 28, 2020
|
|
||
| import angular, { IWindowService } from 'angular'; | ||
| // required for `ngSanitize` angular module | ||
| import 'angular-sanitize'; |
Contributor
There was a problem hiding this comment.
I actually already have this in my NP pr here Maybe this can be removed then? (to avoid merge conflicts). I can just add the comment so it follows the same pattern. wdyt?
Contributor
Author
There was a problem hiding this comment.
I don't think this will cause merge conflicts if the change is the same, and we probably shouldn't add a dependency on that PR to make this PR "complete"
Contributor
There was a problem hiding this comment.
It's the same, but I moved everything outside the legacy directory (and the file name is also different) thus github won't track it as same (and won't do its "auto-merge" magic).
Just thought I should bring it up, so you're not confused with the deleted modules.ts file when trying to merge and resolve conflicts (if my PR goes into master first that is)
Contributor
|
@spalger I'm wondering if we should also do this for |
Contributor
Author
I don't see any reason not to, but we should do it in a separate PR if so. |
igoristic
approved these changes
Apr 28, 2020
Contributor
igoristic
left a comment
igoristic
left a comment
There was a problem hiding this comment.
Looks good 👍 Thank you for adding this!
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Apr 29, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 29, 2020
* master: (60 commits) [SIEM] Create template timeline (elastic#63136) load react component lazily in so management section (elastic#64285) Cleanup .eslingignore and add target (elastic#64617) [Ingest] Support yaml variables in datasource (elastic#64459) typescript-ify portions of src/optimize (elastic#64688) [ngSanitize] add explicit dependencies to all uses of `ngSanitize` angular module (elastic#64546) Consolidate downloading plugin bundles to bootstrap script (elastic#64685) [Maps] disable edit layer button when flyout is open for add layer or map settings (elastic#64230) chore(NA): add async import into infra plugin to reduce apm bundle size (elastic#63292) [Maps] fix edit filter (elastic#64586) [SIEM][Detections] Adds large list support using REST endpoints Replace a number of any-ed styled(eui*) with accurate types (elastic#64555) [Endpoint] Recursive resolver children (elastic#61914) [ML] Fix new job wizard with multiple indices (elastic#64567) Use short URLs for legacy plugin deprecation warning (elastic#64540) [Uptime] Update uptime ml job id to limit to 64 char (elastic#64394) [Ingest] Fix GET /enrollment-api-keys/null error (elastic#64595) Consolidate cross-cutting concerns between region & coordinate maps in new maps_legacy plugin (elastic#64123) ES UI new platform cleanup (elastic#64332) [Event Log] use @timestamp field for queries (elastic#64391) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 29, 2020
* alerting/np-migration: (64 commits) [ML] Changes Machine learning overview UI text (elastic#64625) [Uptime] Migrate client to New Platform (elastic#55086) Slim vis type timeseries (elastic#64631) [Telemetry] Fix inconsistent search behaviour in Advanced Settings (elastic#64510) removed unneeded dep and file [SIEM] Create template timeline (elastic#63136) load react component lazily in so management section (elastic#64285) Cleanup .eslingignore and add target (elastic#64617) [Ingest] Support yaml variables in datasource (elastic#64459) typescript-ify portions of src/optimize (elastic#64688) [ngSanitize] add explicit dependencies to all uses of `ngSanitize` angular module (elastic#64546) Consolidate downloading plugin bundles to bootstrap script (elastic#64685) [Maps] disable edit layer button when flyout is open for add layer or map settings (elastic#64230) chore(NA): add async import into infra plugin to reduce apm bundle size (elastic#63292) [Maps] fix edit filter (elastic#64586) [SIEM][Detections] Adds large list support using REST endpoints Replace a number of any-ed styled(eui*) with accurate types (elastic#64555) [Endpoint] Recursive resolver children (elastic#61914) [ML] Fix new job wizard with multiple indices (elastic#64567) Use short URLs for legacy plugin deprecation warning (elastic#64540) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've heard that some people are experiencing
Module 'ngSanitize' not availableerrors caused by running Kibana with a number of plugin's disabled. Unfortunately this is going to happen with Angular modules as it is very easy to have a very implicit dependency on other Angular modules without anyone knowing. Additionally, every module for the most part populates a global module registry making disabling even a few plugins cause these types of errors. Usually the solution is just to make the dependency on specific modules more explicit by putting bareimport "<module>"statements in any file that uses that npm module's Angular modules, as seen here for theangular-sanitizenpm module and thengSanitizeAngular module.