Skip to content

[SIEM] Register uiSettings on New Platform #64015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2020
Merged

[SIEM] Register uiSettings on New Platform #64015

merged 1 commit into from
Apr 21, 2020

Conversation

@rylnd
Copy link
Contributor

@rylnd rylnd commented Apr 20, 2020 •
edited
Loading

Summary

A precursor to the client migration to NP (#45831), this moves UISettings registration into the NP server plugin.

This new API requires us to define a schema for each setting, which is a
little redundant given that we also have to type the useUiSetting calls;
this might be an issue between kibana-react and new UiSettings changes, but I've created a separate issue to track that.

For maintainers

@rylnd
Register uiSettings on New Platform
7a4fcb0 
This now requires us to define a schema for each setting, which is a
little redundant given that we also have to type the useUiSetting calls;
this might be an issue between kibana-react and new UiSettings changes.
@rylnd rylnd added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels Apr 20, 2020
@rylnd rylnd requested a review from a team as a code owner April 20, 2020 22:11
@rylnd rylnd self-assigned this Apr 20, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 20, 2020

Pinging @elastic/siem (Team:SIEM)

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 20, 2020

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd mentioned this pull request Apr 21, 2020
Merged
1 task
spong
spong reviewed Apr 21, 2020
View reviewed changes
x-pack/plugins/siem/server/ui_settings.ts
Comment on lines +30 to +34
[DEFAULT_SIEM_REFRESH_INTERVAL]: {
type: 'json',
name: i18n.translate('xpack.siem.uiSettings.defaultRefreshIntervalLabel', {
defaultMessage: 'Time filter refresh interval',
}),
Copy link
Member

@spong spong Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this setting may be broken? Modifying it to the below configuration on either this branch or master (siem-dev) does not result in any changes to the datepicker Refresh every UI.

This appears to be pre-existing, so no need to fix here. I've opened this issue to track: #64034. It looks like the setting isn't being read correctly and it just comes back as null.

Config:

{
  "pause": false,
  "value": 230000
}

Result:

Copy link
Contributor Author

@rylnd rylnd Apr 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, I'll follow up on that issue.

spong
spong approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out, tested locally, and performed code review -- LGTM! 👍

Note: I found #64034 in testing this PR, but it appears to be a pre-existing issue, so no need to fix as part of this unless you really want to. 🙂

FrankHassanabad
FrankHassanabad approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but ensure you read through @spong 's comments

@rylnd rylnd merged commit 5a55c9a into elastic:master Apr 21, 2020
@rylnd rylnd deleted the siem_ui_settings_registration branch April 21, 2020 17:47
@rylnd rylnd mentioned this pull request Apr 21, 2020
Merged
rylnd added a commit that referenced this pull request Apr 21, 2020
@rylnd
Register uiSettings on New Platform (#64015) (#64094)
0c4d33c 
This now requires us to define a schema for each setting, which is a
little redundant given that we also have to type the useUiSetting calls;
this might be an issue between kibana-react and new UiSettings changes.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 22, 2020
@gmmorris
Merge branch 'master' into alerting/no-explicit-any
02077cc 
* master: (29 commits)
  [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611)
  refactor action filter creation utils (elastic#62969)
  Refresh index pattern list before redirecting (elastic#63329)
  [APM]fixing custom link unit tests (elastic#64045)
  [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103)
  [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033)
  [Maps] Map settings: min and max zoom (elastic#63714)
  [kbn-storybook] Use raw loader for text files (elastic#64108)
  [EPM] /packages/{package} endpoint to support upgrades (elastic#63629)
  [SIEM] New Platform Saved Objects Registration (elastic#64029)
  [Endpoint] Hook to handle events needing navigation via Router (elastic#63863)
  Fixed small issue in clone functionality (elastic#64085)
  [Endpoint]EMT-146: use ingest agent for status info (elastic#63921)
  [SIEM] Server NP Followup (elastic#64010)
  Register uiSettings on New Platform (elastic#64015)
  [Reporting] Integration polling config with client code (elastic#63754)
  [Docs]7.7 SIEM doc updates (elastic#63951)
  [SIEM] [Cases] Tags suggestions (elastic#63878)
  Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027)
  [DOCS] Add file size setting for Data Visualizer (elastic#64006)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 22, 2020
@gmmorris
Merge branch 'task-manager/cancel-logging' of github.com:gmmorris/kib…
c3b9f64 
…ana into task-manager/cancel-logging

* 'task-manager/cancel-logging' of github.com:gmmorris/kibana: (28 commits)
  [Dashboard] Deangularize navbar, attempt nr. 2 (elastic#61611)
  refactor action filter creation utils (elastic#62969)
  Refresh index pattern list before redirecting (elastic#63329)
  [APM]fixing custom link unit tests (elastic#64045)
  [Ingest] EPM & Fleet are enabled when Ingest is enabled (elastic#64103)
  [Alerting] Fixed bug with no possibility to edit the index name after adding (elastic#64033)
  [Maps] Map settings: min and max zoom (elastic#63714)
  [kbn-storybook] Use raw loader for text files (elastic#64108)
  [EPM] /packages/{package} endpoint to support upgrades (elastic#63629)
  [SIEM] New Platform Saved Objects Registration (elastic#64029)
  [Endpoint] Hook to handle events needing navigation via Router (elastic#63863)
  Fixed small issue in clone functionality (elastic#64085)
  [Endpoint]EMT-146: use ingest agent for status info (elastic#63921)
  [SIEM] Server NP Followup (elastic#64010)
  Register uiSettings on New Platform (elastic#64015)
  [Reporting] Integration polling config with client code (elastic#63754)
  [Docs]7.7 SIEM doc updates (elastic#63951)
  [SIEM] [Cases] Tags suggestions (elastic#63878)
  Include datasource UUID in agent config yaml, adjust overflow height of yaml view (elastic#64027)
  [DOCS] Add file size setting for Data Visualizer (elastic#64006)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 23, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spong spong spong approved these changes

@andrew-goldstein andrew-goldstein Awaiting requested review from andrew-goldstein

@XavierM XavierM Awaiting requested review from XavierM

+1 more reviewer

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rylnd rylnd

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rylnd @elasticmachine @kibanamachine @FrankHassanabad @spong @MindyRS