Skip to content

[Maps] Migrate Maps embeddables to NP #63976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2020
Merged

[Maps] Migrate Maps embeddables to NP #63976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebccdcf
Migrate maps embeddables. Clean up legacy presence
Apr 20, 2020
6e8b387
Fix type error
Apr 22, 2020
93f4c8c
Merge branch 'master' into np-migrate-embeddables
elasticmachine Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion x-pack/legacy/plugins/maps/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ export function maps(kibana) {
tilemap: _.get(mapConfig, 'tilemap', []),
};
},
embeddableFactories: ['plugins/maps/embeddable/map_embeddable_factory'],
styleSheetPaths: `${__dirname}/public/index.scss`,
savedObjectSchemas: {
'maps-telemetry': {
Expand Down
30 changes: 0 additions & 30 deletions x-pack/legacy/plugins/maps/public/embeddable/map_embeddable_factory.ts
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion x-pack/plugins/maps/kibana.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@
"configPath": ["xpack", "maps"],
"requiredPlugins": [
"inspector",
"licensing",
"home",
"data",
"fileUpload",
"uiActions",
"navigation",
"visualizations"
"visualizations",
"embeddable"
],
"ui": true
}
7 changes: 6 additions & 1 deletion x-pack/plugins/maps/public/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,15 @@ import { getMapsVisTypeAlias } from './maps_vis_type_alias';
import { registerLayerWizards } from './layers/load_layer_wizards';
import { HomePublicPluginSetup } from '../../../../src/plugins/home/public';
import { VisualizationsSetup } from '../../../../src/plugins/visualizations/public';
import { MAP_SAVED_OBJECT_TYPE } from '../common/constants';
import { MapEmbeddableFactory } from './embeddable';
import { EmbeddableSetup } from '../../../../src/plugins/embeddable/public';

export interface MapsPluginSetupDependencies {
inspector: InspectorSetupContract;
home: HomePublicPluginSetup;
visualizations: VisualizationsSetup;
embeddable: EmbeddableSetup;
}
// eslint-disable-next-line @typescript-eslint/no-empty-interface
export interface MapsPluginStartDependencies {}
Expand Down Expand Up @@ -102,12 +106,13 @@ export class MapsPlugin
MapsPluginStartDependencies
> {
public setup(core: CoreSetup, plugins: MapsPluginSetupDependencies) {
const { inspector, home, visualizations } = plugins;
const { inspector, home, visualizations, embeddable } = plugins;
bindSetupCoreAndPlugins(core, plugins);

inspector.registerView(MapView);
home.featureCatalogue.register(featureCatalogueEntry);
visualizations.registerAlias(getMapsVisTypeAlias());
embeddable.registerEmbeddableFactory(MAP_SAVED_OBJECT_TYPE, new MapEmbeddableFactory());
}

public start(core: CoreStart, plugins: any) {
Expand Down