fix(NA): node module main field resolution for new platform #63886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
spalger
approved these changes
Apr 17, 2020
Contributor
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
This is the setting we've been using in the base optimizer, so I'm fine using it, and the default is ['browser', 'module', 'main'], I'm wondering if we actually need the browserify entry but LGTM either way.
Member
Author
|
@spalger I don't think we need the |
Merged
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Member
Author
|
7.x: 07c7ee2 |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Apr 23, 2020
…63886) * fix(NA): node module main field resolution for new platform * chore(NA): remove browserify from kbn optimizer main fields Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Apr 23, 2020
…63886) * fix(NA): node module main field resolution for new platform * chore(NA): remove browserify from kbn optimizer main fields Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mistic
added a commit
that referenced
this pull request
Apr 23, 2020
…64302) * fix(NA): node module main field resolution for new platform * chore(NA): remove browserify from kbn optimizer main fields Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mistic
added a commit
that referenced
this pull request
Apr 24, 2020
…64304) * fix(NA): node module main field resolution for new platform * chore(NA): remove browserify from kbn optimizer main fields Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That adds the same mainFields resolution we were using in the legacy optimizer in order to make the
disallow syntax ruleto work correctly.