[Mappings editor] Add component integration tests #63853

sebelga · 2020-04-17T14:10:26Z

This PR adds component integration tests coverage to the mappings editor.

What is currently tested

Core

Default behavior of the mappings editor: converting a field with no type defined to an object types and adding default _meta and _source objects.
Component props (value and onChange): make sure the component renders the correct values and that it forwards to the consumer component the changes.

Mapped fields

Make sure the correct DOM tree renders for the provided mappings properties
Make sure the mappings editor can be controlled and that the DOM tree updates when a new value is provided

Edit field

Make sure the correct field is edited (title & path)
Advanced settings are hidden by default
Changing field datatype updates the form correctly with the new parameters

Datatypes

Text

Make sure the correct default parameters are sent back.
Default values for searchable, index analyzer, search analyzer and search_quote analyzer
When analyzer with sub-select (e.g. language -> french), make sure both dropdown selects have the correct default value
Checkbox for the "Use same analyzer for search" logic
Allow custom analyzer to be inserted manually with a text input
Provide Index settings to the Mappings editor and verify that the custom analyzers are displayed under 2 dropdown selects "Custom -> "

Shape

Make sure the correct default parameters are sent back.

Bug fixes

The following bugs have been fixed

In the "Advanced options", the "Map numeric strings as numbers" toggle was controlling the value of the "Throw an exception when a document contains an unmapped field" (visible when "Enable dynamic mappings" is set to false). Updating one was updating the other.
In the text analyzers, when there is a second "sub" select (ex. for "languages"), the default value was wrongly set on the first option. So if we were loading a "french" analyzer, it would display "Arabic" in the dropdown.

Other changes

I also updated the Mappings editor props to follow the convention

value instead of defaultValue as the component can be controlled by the consumer and updates its internal state accordingly
onChange instead of `onUpdate

cc @cuff-links

elasticmachine · 2020-04-22T12:26:13Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

…ectly

…gs provided

sebelga · 2020-05-02T12:11:07Z

@elasticmachine merge upstream

cuff-links · 2020-05-03T18:22:19Z

@elasticmachine merge upstream

sebelga · 2020-05-04T07:23:20Z

@cuff-links Thanks for the review! To modify the jest script this would be something to ask to the operation team if we think it is worth it.
What I think would be more interesting is to be able to run the Jest test 50 times for a specific plugin in isolation.

sebelga · 2020-05-04T07:23:45Z

@elasticmachine merge upstream

sebelga · 2020-05-04T12:39:51Z

@elasticmachine merge upstream

cjcenizal

Great work, Seb! Code looks great overall. I had a few suggestions that would have helped me understand the tests and also a couple of questions. I'd love to see them addressed but I don't think we need to block on them.

x-pack/plugins/index_management/public/application/components/mappings_editor/lib/utils.test.ts

.../application/components/mappings_editor/__jest__/client_integration/mappings_editor.test.tsx

...ion/components/mappings_editor/__jest__/client_integration/datatypes/shape_datatype.test.tsx

...tion/components/mappings_editor/__jest__/client_integration/datatypes/text_datatype.test.tsx

...omponents/mappings_editor/components/document_fields/field_parameters/analyzer_parameter.tsx

.../application/components/mappings_editor/components/configuration_form/configuration_form.tsx

x-pack/test_utils/testbed/testbed.ts

sebelga · 2020-05-06T09:55:07Z

@elasticmachine merge upstream

sebelga · 2020-05-06T15:02:25Z

@elasticmachine merge upstream

sebelga · 2020-05-06T15:11:25Z

Thanks for the review @cjcenizal ! I address most of your concerns 👍

sebelga · 2020-05-07T06:44:31Z

@elasticmachine merge upstream

kibanamachine · 2020-05-07T08:38:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: df5be1c

History

💔 Build #45985 failed 793bbdc
💔 Build #45944 failed ab76582
💛 Build #45902 was flaky c56cb07
💔 Build #44961 failed 70bf068
💔 Build #44847 failed fe92ac4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ttional-flaky * upstream/master: (49 commits) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491) fix SavedObjectMigrationMap type (elastic#65569) [Uptime] Improve cert flaky test (elastic#65458) [Uptime] Fix monitor list result runtime type, ip can be null (elastic#65532) [APM] Agent configuration: Bug makes it possible to create invalid configurations (elastic#65508) [APM] Remove link from active page in the breadcrumb (elastic#65473) [SIEM] Fixes test flakiness (elastic#65510) [ESLint] update @kbn/eslint/no-restricted-paths rule to allow imports mocks from folder (elastic#65471) Migrate test plugins ⇒ NP (kbn_tp_run_pipeline) (elastic#64780) move core provier to NP. allows to run tests on every page (elastic#64929) Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors (elastic#65201) [functional tests] add some missing awaits (elastic#65566) Fixed create new connector from alert flyout form throw an error messages in external plugins. (elastic#65539) [SIEM] [Cases] External services not getting all comments bug fix (elastic#65307) ...

* master: [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)

…ponents * alerting/lazy-load-actions: align and style loading indicator [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)

)

sebelga force-pushed the test/mappings-editor branch from 7078966 to 5ea0be5 Compare April 22, 2020 12:24

sebelga added Feature:Mappings Editor Index mappings editor UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// test-jest-integration v8.0.0 labels Apr 22, 2020

sebelga added the v7.8.0 label Apr 22, 2020

sebelga force-pushed the test/mappings-editor branch 2 times, most recently from d85f23c to fb4d980 Compare April 27, 2020 09:26

sebelga added 21 commits April 27, 2020 12:54

Test props.onUpdate() to make sure it forwards data to consumer

1318726

Test props.defaultValue to make sure the editor is pre-populated corr…

bf6be1e

…ectly

Fix test and add missing "key" element on UseField components

50a6f92

Move expectDataUpdatedFactory to helpers and add editField helper

60c87ee

[testbed] Add "waitForFn" helper to wait for a predicate function

841b8d0

Add test of edit field (flyout) initial view

8385484

[mappings editor] Strip undefined value from object returned

dce1813

Test that default parameters values are added to the field when updated

5feedcc

Remove unused

905bae7

Fix strip undefined logic to support Array and Date instances

91a3b7b

Add expandAllFields helper

ab0ecd7

Refactor helper to get data forwarded to consumer component

04930f7

Move the beforeEach logic inside the test

21513e9

Add coverage for analyzer default value and changes

b26f5c8

Fix act() error

93388a3

Fix TS issue

a01f522

Test custom analyzer of external plugins

9a8d9b5

Test custom analyzer declared on index settings

01605db

Fix default value for second dropdown select of analyzers

2fe79d0

Fix failing test

0f97d1f

Add mapped field test to make sure the DOM tree represents the mappin…

2b63142

…gs provided

Merge branch 'master' into test/mappings-editor

4fc1055

Merge branch 'master' into test/mappings-editor

fe92ac4

Merge branch 'master' into test/mappings-editor

70bf068

cjcenizal mentioned this pull request May 5, 2020

Remove es_ui_shared static directory #65301

Open

cjcenizal approved these changes May 6, 2020

View reviewed changes

elasticmachine and others added 2 commits May 6, 2020 05:55

Merge branch 'master' into test/mappings-editor

c56cb07

Address CR changes

ab76582

Merge branch 'master' into test/mappings-editor

793bbdc

Merge branch 'master' into test/mappings-editor

df5be1c

sebelga merged commit 83a088c into elastic:master May 7, 2020

sebelga deleted the test/mappings-editor branch May 7, 2020 09:47

sebelga mentioned this pull request May 7, 2020

[7.x] [Mappings editor] Add component integration tests (#63853) #65648

Merged

sebelga added v7.9.0 and removed v7.8.0 labels May 7, 2020

sebelga added a commit that referenced this pull request May 7, 2020

[7.x] [Mappings editor] Add component integration tests (#63853) (#65648

20be558

)

mistic mentioned this pull request May 11, 2020

chore(NA): skip mapping editor shape datatype test #66041

Merged

spalger mentioned this pull request May 13, 2020

Failing test: X-Pack Jest Tests.x-pack/plugins/index_management/public/application/components/mappings_editor/__jest__/client_integration - Mappings editor: core tabs should keep the changes when switching tabs #66457

Closed

[Mappings editor] Add component integration tests #63853

[Mappings editor] Add component integration tests #63853

Uh oh!

Conversation

sebelga commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is currently tested

Core

Mapped fields

Edit field

Datatypes

Text

Shape

Bug fixes

Other changes

Uh oh!

elasticmachine commented Apr 22, 2020

Uh oh!

sebelga commented May 2, 2020

Uh oh!

cuff-links commented May 3, 2020

Uh oh!

sebelga commented May 4, 2020

Uh oh!

sebelga commented May 4, 2020

Uh oh!

sebelga commented May 4, 2020

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sebelga commented May 6, 2020

Uh oh!

sebelga commented May 6, 2020

Uh oh!

sebelga commented May 6, 2020

Uh oh!

sebelga commented May 7, 2020

Uh oh!

kibanamachine commented May 7, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sebelga commented Apr 17, 2020 •

edited

Loading