[eslint] no_restricted_paths config cleanup #63741

tylersmalley · 2020-04-16T18:23:55Z

Refactor/fixes of the no_restricted_paths rule config for imports of core.

In no_restricted_paths we resolve relative imports with eslint-module-utils/resolve which resolves to the full filesystem path. So, to support relative and absolute imports from the src alias we need to define both the directory and the index including file extension. An alternative could be to change how we handle this in no_restricted_paths by checking if it's a node_module or from source.

This rule was handling both core imports, as well as imports from other plugins. Imports from other plugins are being used much more liberally allowed through the exceptions in tests. I choose to break these up, removing this exception for tests for core imports.

Fixes:

Absolute imports of src/core/server/mocks were not allowed in src. This was not an issue in x-pack due to the target excluding !x-pack/**/*.test.* and !x-pack/test/**/*.
Non-top-level public and server imports were allowed from X-Pack tests to the previously mentioned exclusion.

elasticmachine · 2020-04-16T22:05:02Z

Pinging @elastic/uptime (Team:uptime)

Major cleanup of the no_restricted_paths rule for imports of core. For relative imports, we use eslint-module-utils/resolve which resolves to the full filesystem path. So, to support relative and absolute imports from the src alias we need to define both the directory and the index including file extension. This rule was handling both core imports, as well as imports from other plugins. Imports from other plugins are being used much more liberally allowed through the exceptions in tests. I choose to break these up, removing this exception for tests for core imports. Fixes: Absolute imports of src/core/server/mocks were not allowed in src. This was not an issue in x-pack due to the target excluding !x-pack/**/*.test.* and !x-pack/test/**/*. Non-top-level public and server imports were allowed from X-Pack tests to the previously mentioned exclusion. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley · 2020-04-20T14:57:27Z

src/core/public/index.ts

 export {
  HttpHeadersInit,
  HttpRequestInit,
+  HttpFetchError,


Are we OK with this? It's being requested from tests, so either we can add src/core/public/http as an exception to the ESLint rule, or we can exempt tests from requiring top level imports.

cc: @elastic/kibana-platform

jen-huang

Ingest manager changes LGTM

elasticmachine · 2020-04-20T16:53:15Z

Pinging @elastic/kibana-operations (Team:Operations)

elasticmachine · 2020-04-20T16:53:17Z

Pinging @elastic/kibana-platform (Team:Platform)

joshdover

Need to test this locally still, but a couple comments

.eslintrc.js

jportner

Security changes LGTM.

patrykkopycinski

SIEM changes LGTM 💪

cjcenizal

Code changes to Upgrade Assistant LGTM, didn't test locally.

mikecote

Alerting code LGTM

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

kibanamachine · 2020-04-23T20:44:00Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6dd9487

History

💚 Build #42295 succeeded 39ed5d1
💚 Build #41882 succeeded a332507
💔 Build #41572 failed 06695cd4c7a140bd5eef0cd4fcd908ded28a01c9
💔 Build #41451 failed 4943b3e05b179b6fec140939b5be83a4c97172bb
💔 Build #41424 failed c746917d184bc6c237219116e0f5a29906e337b3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

tylersmalley · 2020-04-23T23:02:44Z

Waiting for #64306 to be merged before backporting to 7.x

* master: (70 commits) KQL removes leading zero and breaks query (elastic#62748) [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType (elastic#64193) [ML] Changes transforms wizard UI text (elastic#64150) [Alerting] change server log action type .log to .server-log in README (elastic#64124) [Metrics UI] Design Refresh: Inventory View, Episode 1 (elastic#64026) chore(NA): reduce siem bundle size using babel-plugin-transfor… (elastic#63269) chore(NA): use core-js instead of babel-polyfill on canvas sha… (elastic#63486) skip flaky suite (elastic#61173) skip flaky suite (elastic#62497) Renamed ilm policy for event log so it is not prefixed with dot (elastic#64262) [eslint] no_restricted_paths config cleanup (elastic#63741) Add Oil Rig Icon from @elastic/maki (elastic#64364) [Maps] Migrate Maps embeddables to NP (elastic#63976) [Ingest] Data streams list page (elastic#64134) chore(NA): add file-loader into jest moduleNameMapper (elastic#64330) [DOCS] Added images to automating report generation (elastic#64333) [SIEM][CASE] Api Integration Tests: Configuration (elastic#63948) Expose ability to check if API Keys are enabled (elastic#63454) [DOCS] Fixes formatting in alerting doc (elastic#64338) [data.search.aggs]: Create agg types function for terms agg. (elastic#63541) ...

Major cleanup of the no_restricted_paths rule for imports of core. For relative imports, we use eslint-module-utils/resolve which resolves to the full filesystem path. So, to support relative and absolute imports from the src alias we need to define both the directory and the index including file extension. This rule was handling both core imports, as well as imports from other plugins. Imports from other plugins are being used much more liberally allowed through the exceptions in tests. I choose to break these up, removing this exception for tests for core imports. Fixes: Absolute imports of src/core/server/mocks were not allowed in src. This was not an issue in x-pack due to the target excluding !x-pack/**/*.test.* and !x-pack/test/**/*. Non-top-level public and server imports were allowed from X-Pack tests to the previously mentioned exclusion. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley force-pushed the eslint-ts branch from 0464330 to 032bcc4 Compare April 16, 2020 22:04

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 16, 2020

tylersmalley changed the title ~~[eslint] Removes extensions from no_restricted_paths config~~ [eslint] Allows for relative and absolute import into core for no_restricted_paths config Apr 16, 2020

tylersmalley force-pushed the eslint-ts branch 2 times, most recently from c746917 to 1f0484b Compare April 17, 2020 02:04

tylersmalley changed the title ~~[eslint] Allows for relative and absolute import into core for no_restricted_paths config~~ [eslint] no_restricted_paths config cleanup Apr 17, 2020

tylersmalley force-pushed the eslint-ts branch 4 times, most recently from 12d95a3 to 06695cd Compare April 17, 2020 14:35

tylersmalley force-pushed the eslint-ts branch from 06695cd to a332507 Compare April 20, 2020 14:41

tylersmalley commented Apr 20, 2020

View reviewed changes

tylersmalley mentioned this pull request Apr 20, 2020

[Dashboard] Moves migrations to new platform #63656

Closed

tylersmalley marked this pull request as ready for review April 20, 2020 16:49

tylersmalley requested a review from a team as a code owner April 20, 2020 16:49

tylersmalley requested a review from a team April 20, 2020 16:49

tylersmalley requested review from a team as code owners April 20, 2020 16:49

jen-huang approved these changes Apr 20, 2020

View reviewed changes

tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.8.0 v8.0.0 labels Apr 20, 2020

joshdover reviewed Apr 20, 2020

View reviewed changes

.eslintrc.js Show resolved Hide resolved

.eslintrc.js Outdated Show resolved Hide resolved

.eslintrc.js Outdated Show resolved Hide resolved

jportner approved these changes Apr 20, 2020

View reviewed changes

patrykkopycinski approved these changes Apr 20, 2020

View reviewed changes

cjcenizal approved these changes Apr 20, 2020

View reviewed changes

mikecote approved these changes Apr 21, 2020

View reviewed changes

Tyler Smalley added 3 commits April 21, 2020 14:09

Merge remote-tracking branch 'upstream/master' into eslint-ts

837263c

Use brace expansion

39ed5d1

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Merge remote-tracking branch 'upstream/master' into eslint-ts

6dd9487

joshdover approved these changes Apr 23, 2020

View reviewed changes

tylersmalley merged commit feed406 into elastic:master Apr 23, 2020

tylersmalley mentioned this pull request Apr 23, 2020

[7.x] [Ingest] Encrypt secrets in fleet saved objects (#63982) #64306

Merged

tylersmalley mentioned this pull request Apr 24, 2020

[7.x] [eslint] no_restricted_paths config cleanup (#63741) #64431

Merged

joshdover mentioned this pull request Apr 26, 2020

improve no-restricted-path rule from kbn-eslint-plugin-eslint to handle absolute paths. #36096

Closed

[eslint] no_restricted_paths config cleanup #63741

[eslint] no_restricted_paths config cleanup #63741

Uh oh!

Conversation

tylersmalley commented Apr 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Apr 16, 2020

Uh oh!

tylersmalley Apr 20, 2020

Choose a reason for hiding this comment

Uh oh!

tylersmalley Apr 20, 2020

Choose a reason for hiding this comment

Uh oh!

jen-huang left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 20, 2020

Uh oh!

elasticmachine commented Apr 20, 2020

Uh oh!

joshdover left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jportner left a comment

Choose a reason for hiding this comment

Uh oh!

patrykkopycinski left a comment

Choose a reason for hiding this comment

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

Uh oh!

mikecote left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Apr 23, 2020

💚 Build Succeeded

History

Uh oh!

tylersmalley commented Apr 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

tylersmalley commented Apr 16, 2020 •

edited

Loading