[Dashboard] Moves migrations to new platform

src/core/server/index.ts

@@ -176,7 +176,7 @@ export {
   SafeRouteMethod,
 } from './http';
 export { RenderingServiceSetup, IRenderOptions } from './rendering';
-export { Logger, LoggerFactory, LogMeta, LogRecord, LogLevel } from './logging';
+export { Logger, LoggerFactory, LogMeta, LogRecord, LogLevel, loggerMock } from './logging';
 
 export {
   DiscoveredPlugin,
@@ -220,6 +220,7 @@ export {
   SavedObjectsMigrationLogger,
   SavedObjectsRawDoc,
   SavedObjectSanitizedDoc,
+  SavedObjectUnsanitizedDoc,
   SavedObjectsRepositoryFactory,
   SavedObjectsResolveImportErrorsOptions,
   SavedObjectsSchema,

src/core/server/logging/index.ts

@@ -21,6 +21,8 @@ export { Logger, LogMeta } from './logger';
 export { LoggerFactory } from './logger_factory';
 export { LogRecord } from './log_record';
 export { LogLevel } from './log_level';
+export { loggerMock } from './logger.mock';
+
 /** @internal */
 export { config, LoggingConfigType } from './logging_config';
 /** @internal */

src/core/server/saved_objects/migrations/core/document_migrator.test.ts

@@ -587,7 +587,7 @@ describe('DocumentMigrator', () => {
         migrations: {
           '1.2.3': (doc, { log }) => {
             log.info(logTestMsg);
-            log.warning(logTestMsg);
+            log.warn(logTestMsg);
             return doc;
           },
         },

src/core/server/saved_objects/migrations/core/migration_coordinator.ts

@@ -97,7 +97,7 @@ function handleIndexExists(error: any, log: SavedObjectsMigrationLogger) {
 
   const index = _.get(error, 'body.error.index');
 
-  log.warning(
+  log.warn(
     `Another Kibana instance appears to be migrating the index. Waiting for ` +
       `that migration to complete. If no other Kibana instance is attempting ` +
       `migrations, you can get past this message by deleting index ${index} and ` +

src/core/server/saved_objects/migrations/core/migration_logger.ts

@@ -33,7 +33,7 @@ export interface SavedObjectsMigrationLogger {
   /**
    * @deprecated Use `warn` instead.
    */
-  warning: (msg: string) => void;
+  warning?: (msg: string) => void;
   warn: (msg: string) => void;
 }
 

src/legacy/core_plugins/kibana/index.js

@@ -21,7 +21,6 @@ import Fs from 'fs';
 import { resolve } from 'path';
 import { promisify } from 'util';
 
-import { migrations } from './migrations';
 import { importApi } from './server/routes/api/import';
 import { exportApi } from './server/routes/api/export';
 import mappings from './mappings.json';
@@ -124,23 +123,6 @@ export default function(kibana) {
       ],
 
       savedObjectsManagement: {
-        dashboard: {
-          icon: 'dashboardApp',
-          defaultSearchField: 'title',
-          isImportableAndExportable: true,
-          getTitle(obj) {
-            return obj.attributes.title;
-          },
-          getEditUrl(obj) {
-            return `/management/kibana/objects/savedDashboards/${encodeURIComponent(obj.id)}`;
-          },
-          getInAppUrl(obj) {
-            return {
-              path: `/app/kibana#/dashboard/${encodeURIComponent(obj.id)}`,
-              uiCapabilitiesPath: 'dashboard.show',
-            };
-          },
-        },
         url: {
           defaultSearchField: 'url',
           isImportableAndExportable: true,
@@ -181,8 +163,6 @@ export default function(kibana) {
 
       mappings,
       uiSettingDefaults: getUiSettingDefaults(),
-
-      migrations,
     },
 
     uiCapabilities: async function() {

src/legacy/core_plugins/kibana/mappings.json

@@ -1,58 +1,4 @@
 {
-  "dashboard": {
-    "properties": {
-      "description": {
-        "type": "text"
-      },
-      "hits": {
-        "type": "integer"
-      },
-      "kibanaSavedObjectMeta": {
-        "properties": {
-          "searchSourceJSON": {
-            "type": "text"
-          }
-        }
-      },
-      "optionsJSON": {
-        "type": "text"
-      },
-      "panelsJSON": {
-        "type": "text"
-      },
-      "refreshInterval": {
-        "properties": {
-          "display": {
-            "type": "keyword"
-          },
-          "pause": {
-            "type": "boolean"
-          },
-          "section": {
-            "type": "integer"
-          },
-          "value": {
-            "type": "integer"
-          }
-        }
-      },
-      "timeFrom": {
-        "type": "keyword"
-      },
-      "timeRestore": {
-        "type": "boolean"
-      },
-      "timeTo": {
-        "type": "keyword"
-      },
-      "title": {
-        "type": "text"
-      },
-      "version": {
-        "type": "integer"
-      }
-    }
-  },
   "url": {
     "properties": {
       "accessCount": {

src/legacy/core_plugins/kibana/public/dashboard/migrations/migrate_to_730_panels.test.ts → src/plugins/dashboard/common/migrate_to_730_panels.test.ts

@@ -27,7 +27,7 @@ import {
   DEFAULT_PANEL_HEIGHT,
   SavedDashboardPanelTo60,
   SavedDashboardPanel730ToLatest,
-} from '../../../../../../plugins/dashboard/public';
+} from '../public';
 
 test('6.0 migrates uiState, sort, scales, and gridData', async () => {
   const uiState = {

src/legacy/core_plugins/kibana/public/dashboard/migrations/migrate_to_730_panels.ts → src/plugins/dashboard/common/migrate_to_730_panels.ts

@@ -31,7 +31,7 @@ import {
   SavedDashboardPanel620,
   SavedDashboardPanel630,
   SavedDashboardPanel610,
-} from '../../../../../../plugins/dashboard/public';
+} from '../public';
 
 const PANEL_HEIGHT_SCALE_FACTOR = 5;
 const PANEL_HEIGHT_SCALE_FACTOR_WITH_MARGINS = 4;

src/plugins/dashboard/public/application/lib/migrate_app_state.ts

@@ -33,7 +33,7 @@ import {
   SavedDashboardPanel,
 } from '../../types';
 // should be moved in src/plugins/dashboard/common right after https://github.com/elastic/kibana/pull/61895 is merged
-import { migratePanelsTo730 } from '../../../../../legacy/core_plugins/kibana/public/dashboard/migrations/migrate_to_730_panels';
+import { migratePanelsTo730 } from '../../../common/migrate_to_730_panels';
 
 /**
  * Attempts to migrate the state stored in the URL into the latest version of it.

src/legacy/core_plugins/kibana/migrations/is_doc.ts → src/plugins/dashboard/server/index.ts

@@ -17,15 +17,14 @@
  * under the License.
  */
 
-import { Doc } from './types';
+import { PluginInitializerContext } from '../../../core/server';
+import { DashboardsPlugin } from './plugin';
 
-export function isDoc(doc: { [key: string]: unknown } | Doc): doc is Doc {
-  return (
-    typeof doc.id === 'string' &&
-    typeof doc.type === 'string' &&
-    doc.attributes !== null &&
-    typeof doc.attributes === 'object' &&
-    doc.references !== null &&
-    typeof doc.references === 'object'
-  );
+//  This exports static code and TypeScript types,
+//  as well as, Kibana Platform `plugin()` initializer.
+
+export function plugin(initializerContext: PluginInitializerContext) {
+  return new DashboardsPlugin(initializerContext);
 }
+
+export { DashboardsPluginSetup, DashboardsPluginStart } from './types';

src/plugins/dashboard/server/plugin.ts

@@ -0,0 +1,53 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import {
+  PluginInitializerContext,
+  CoreSetup,
+  CoreStart,
+  Plugin,
+  Logger,
+} from '../../../core/server';
+
+import { dashboardSavedObjectType } from './saved_objects';
+
+import { DashboardsPluginSetup, DashboardsPluginStart } from './types';
+
+export class DashboardsPlugin implements Plugin<DashboardsPluginSetup, DashboardsPluginStart> {
+  private readonly logger: Logger;
+
+  constructor(initializerContext: PluginInitializerContext) {
+    this.logger = initializerContext.logger.get();
+  }
+
+  public setup(core: CoreSetup) {
+    this.logger.debug('dashboards: Setup');
+
+    core.savedObjects.registerType(dashboardSavedObjectType);
+
+    return {};
+  }
+
+  public start(core: CoreStart) {
+    this.logger.debug('dashboards: Started');
+    return {};
+  }
+
+  public stop() {}
+}

src/plugins/dashboard/server/saved_objects/dashboard.ts

@@ -0,0 +1,39 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { SavedObjectsType } from 'kibana/server';
+import { dashboardSavedObjectTypeMigrations } from './dashboard_migrations';
+
+export const dashboardSavedObjectType: SavedObjectsType = {
+  name: 'dashboard',
+  hidden: false,
+  namespaceAgnostic: false,
+  mappings: {
+    properties: {
+      description: { type: 'text' },
+      kibanaSavedObjectMeta: { properties: { searchSourceJSON: { type: 'text' } } },
+      savedSearchRefName: { type: 'keyword' },
+      title: { type: 'text' },
+      uiStateJSON: { type: 'text' },
+      version: { type: 'integer' },
+      visState: { type: 'text' },
+    },
+  },
+  migrations: dashboardSavedObjectTypeMigrations,
+};