[Ingest] Allow to enable monitoring of elastic agent #63598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
force-pushed
the
feature-fleet-agent-monitoring
branch
from
1dcd9e9 to
5d030c3
Compare
Member
Author
|
Waiting on @michalpristas tests to figure why the agent is not sending monitoring |
Contributor
|
tested with mock and agent generates monitoring config. need kbn to test more |
nchaulet
force-pushed
the
feature-fleet-agent-monitoring
branch
from
6df0cef to
3c3464d
Compare
Member
Author
|
@michalpristas Did you tested it with kbn? |
Contributor
|
@nchaulet yes i created a basic system configuration with monitoring enabled, enrolled to this config and checked indices and data. pr is not in yet waiting for CI |
jen-huang
approved these changes
Apr 29, 2020
Contributor
jen-huang
left a comment
jen-huang
left a comment
There was a problem hiding this comment.
Code LGTM, didn't test locally
..._manager/public/applications/ingest_manager/sections/agent_config/components/config_form.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+337
to
+338
| logs: config.monitoring_enabled.indexOf('logs') >= 0, | ||
| metrics: config.monitoring_enabled.indexOf('metrics') >= 0, |
Contributor
There was a problem hiding this comment.
Can use .includes instead of .indexOf
…er/sections/agent_config/components/config_form.tsx Co-Authored-By: Jen Huang <its.jenetic@gmail.com>
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
nchaulet
added a commit
that referenced
this pull request
Apr 30, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 30, 2020
* master: (42 commits) [Ingest] Allow aggent to send metadata compliant with ECS (elastic#64452) [Endpoint] Remove todos, urls to issues (elastic#64833) [Uptime] Remove hard coded value for monitor states histograms (elastic#64396) Feature/send feedback link (elastic#64845) [ML] Moving get filters capability to admin (elastic#64879) Remove edit alert button from alerts list (elastic#64643) [EPM] Handle constant_keyword type in KB index patterns and ES index templates (elastic#64876) [ML] Disable data frame anaylics clone button based on permission (elastic#64830) Dashboard url generator to preserve saved filters from destination dashboard (elastic#64767) add generic typings for SavedObjectMigrationFn (elastic#63943) Allow to define and update a defaultPath for applications (elastic#64498) [Event Log] add rel=primary to saved objects for query targets (elastic#64615) [Lens] Use a size of 5 for first string field in visualization (elastic#64726) [SIEM][Lists] Removes plugin dependencies, adds more unit tests, fixes more TypeScript types [Ingest] Edit datasource UI (elastic#64727) [Lens] Bind all time fields to the time picker (elastic#63874) [Lens] Use suggestion system in chart switcher for subtypes (elastic#64613) Improve alpha messaging (elastic#64692) [Ingest] Allow to enable monitoring of elastic agent (elastic#63598) [Metrics UI] Fix alerting when a filter query is present (elastic#64575) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 4, 2020
…bana into pipeline-editor-part-mvp-2 * 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (90 commits) remove unused import address review feedback [Ingest pipelines] Cleanup (elastic#64794) [Ingest] Edit datasource UI (elastic#64727) [Lens] Bind all time fields to the time picker (elastic#63874) [Lens] Use suggestion system in chart switcher for subtypes (elastic#64613) Improve alpha messaging (elastic#64692) [Ingest] Allow to enable monitoring of elastic agent (elastic#63598) [Metrics UI] Fix alerting when a filter query is present (elastic#64575) skip flaky suite (elastic#64812) (elastic#64723) [Maps] do not display EMS or kibana layer wizards when not configured (elastic#64554) [Reporting/Test] Convert functional test code to Typescript (elastic#64601) make inserting timestamp with navigate methods optional with default true (elastic#64655) [EPM] Update UI to handle package versions and updates (elastic#64689) Minimize dependencies required by our telemetry middleware (elastic#64665) [Telemetry] oss api tests (elastic#64602) [ML] Adding endpoint capability checks (elastic#64662) Update jest config for coverage (elastic#64648) [SIEM][NP] Fixes bug in ML signals promotion (elastic#64720) share single data plugin bundle (elastic#64549) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #62141
This PR allow to enable monitoring for elastic agent:
settings.monitoring)Monitoring is enabled by default.
UI changes
Config change
How to test this: enroll an agent with a config with monitoring enabled you should see new indices
