-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[ML] Changing file data visualizer max upload setting to string #63502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jgowdyelastic
merged 1 commit into
elastic:master
from
jgowdyelastic:changing-max-bytes-setting-to-string
Apr 15, 2020
Merged
[ML] Changing file data visualizer max upload setting to string #63502
jgowdyelastic
merged 1 commit into
elastic:master
from
jgowdyelastic:changing-max-bytes-setting-to-string
Apr 15, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Apr 15, 2020
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Member
Author
|
related to #62752 |
alvarezmelissa87
approved these changes
Apr 15, 2020
Contributor
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ⚡
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Apr 15, 2020
jgowdyelastic
added a commit
that referenced
this pull request
Apr 15, 2020
wayneseymour
pushed a commit
that referenced
this pull request
Apr 15, 2020
2 tasks
Contributor
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_discover_histogram·js.discover app discover histogram should visualize monthly data with different day intervalsStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_discover_histogram·js.discover app discover histogram should visualize monthly data with different day intervalsStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:File and Index Data Viz
ML file and index data visualizer
:ml
release_note:enhancement
review
v7.8.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing
max_file_size_bytestomax_file_sizewhich now takes a string value rather than a byte number to make it easier to configure.xpack.ml.file_data_visualizer.max_file_size: '100MB'vs
xpack.ml.file_data_visualizer.max_file_size_bytes: 104857600Release notes should combine this PR with #62752 and #62970 so there is only one feature enhancement mentioned.