[Drilldowns] improve action.getHref() for drilldowns #63228
Conversation
Dosant
added
Feature:UIActions
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
@elasticmachine merge upstream |
| menuPanelItem.onClick = () => { | ||
| action.execute(actionContext); | ||
| menuPanelItem.onClick = event => { | ||
| if (event.target instanceof HTMLAnchorElement) { |
There was a problem hiding this comment.
Maybe this check could be the same as on line 135. I'm thinking of he case where tag might be <a> but action.getHref is not defined.
| if (event.target instanceof HTMLAnchorElement) { | |
| if (action.getHref) { |
There was a problem hiding this comment.
I've actually checked this locally, current behavior is that if you Cmd + Click it does two things: (1) navigates in current tab; (2) opens a new tab. Whereas it should just open a new tab.
The above change actually fixes it—not sure what is happening there but event.target does not seem to be <a>.
There was a problem hiding this comment.
Oh.. thanks! used "wrong" target. So it depended on where you clicked and not on what element handled the event. Should be good now
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
getHref on Action interfaces in uiActions plugin is now async. getHref is now used only to support right click behaviour. execute() takes control on regular click.
getHref on Action interfaces in uiActions plugin is now async. getHref is now used only to support right click behaviour. execute() takes control on regular click.
5 participants
Summary
getHrefasyncto be able to useurlGeneratorinsideDev Docs
getHrefonActioninterfaces in uiActions plugin is now async.getHrefis now used only to support right click behaviour.execute()takes control on regular click.Checklist
Delete any items that are not applicable to this PR.
For maintainers