[Discover] Fix broken setting of bucketInterval #62939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
commented
Apr 8, 2020
| } | ||
| }); | ||
|
|
||
| $scope.$watch('vis.aggs', function() { |
Member
Author
There was a problem hiding this comment.
The watcher didn't work due to the Visualizations API changes, decided it's even not needed and removed it in favor of a simpler solution
kertal
commented
Apr 8, 2020
| ); | ||
| if ($scope.vis.data.aggs.aggs[1]) { | ||
| $scope.bucketInterval = $scope.vis.data.aggs.aggs[1].buckets.getInterval(); | ||
| } |
Member
Author
There was a problem hiding this comment.
dear @ppisljar, this API changed. This works, but I wonder if there's a better way to do it. Before it was done this way:
const buckets = $scope.vis.data.aggs.byTypeName('buckets');
if (buckets && buckets.length === 1) {
$scope.bucketInterval = buckets[0].buckets.getInterval();
}
Member
Author
|
@elasticmachine merge upstream |
…-08-discover-fix-broken-bucket-interval
…l' of github.com:kertal/kibana into kertal-pr-2020-04-08-discover-fix-broken-bucket-interval
kertal
commented
Apr 9, 2020
| }); | ||
|
|
||
| it('should visualize monthly data with different day intervals', async () => { | ||
| //Nov 1, 2017 @ 01:00:00.000 - Mar 21, 2018 @ 02:00:00.000 |
Member
Author
There was a problem hiding this comment.
all the input time ranges in this tests where invalid, fixed that
kertal
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
added
the
release_note:skip
Contributor
|
@elasticmachine merge upstream |
flash1293
approved these changes
Apr 14, 2020
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Tested with time based and time less index pattern, works as expected in all scenarios. Thanks a lot for the functional test! I strongly prefer the new solution.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Apr 15, 2020
* Fix broken setting of bucketInterval, remove $watch * Fix and adapt functional tests
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Apr 15, 2020
* Fix broken setting of bucketInterval, remove $watch * Fix and adapt functional tests
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 15, 2020
* master: (29 commits) Add test:jest_integration npm script (elastic#62938) [data.search.aggs] Remove service getters from agg types (AggConfig part) (elastic#62548) [Discover] Fix broken setting of bucketInterval (elastic#62939) Disable adding conditions when in alert management context. (elastic#63514) [Alerting] fixes to allow pre-configured actions to be executed (elastic#63432) adding useMemo (elastic#63504) [Maps] fix double fetch when filter pill is added (elastic#63024) [Lens] Fix missing formatting bug in "break down by" (elastic#63288) [SIEM] [Cases] Removed double pasted line (elastic#63507) [Reporting] Improve functional test steps (elastic#63259) [SIEM][CASE] Tests for server's configuration API (elastic#63099) [SIEM] [Cases] Case container unit tests (elastic#63376) [ML] Improving parsing of large uploaded files (elastic#62970) [ML] Listing global calendars on the job management page (elastic#63124) [Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint (elastic#63373) Add help text to form fields (elastic#63165) [ML] Converts utils Mocha tests to Jest (elastic#63132) [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) ...
kertal
added a commit
that referenced
this pull request
Apr 15, 2020
kertal
added a commit
that referenced
this pull request
Apr 15, 2020
wayneseymour
pushed a commit
that referenced
this pull request
Apr 15, 2020
* Fix broken setting of bucketInterval, remove $watch * Fix and adapt functional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a manual interval is chosen in Discover histogram which is too small for the current time range, it's scaled up, and the user gets notified by a text. This was broken, due to changes in the Visualizations API, and a watcher was never triggered because of this. This PR restores displaying this information.
Fixes #62753
How to test
Checklist