Fix issue with license not getting obtained & passed to server for legacy maps #62883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindsun
added
Feature:Coordinate Map
Feature:Region Map
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
kindsun
added
the
release_note:skip
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
thomasneirynck
approved these changes
Apr 8, 2020
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
thanks for taking this on. tested and verified this works. nice work cleaning up this dangling issue.
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Apr 8, 2020
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #62856. The x-pack TileMap plugin exists primarily as a license-check. Users with a license that permits usage of x-pack also get map tiles beyond zoom level 10 for legacy maps (Coordinate, Region and Vega). This license check is initially triggered in the plugin via
uiExports > visTypeEnhancersand then executes an update toservice_settingsthrough angular.The issue appears to be with the usage of
visTypeEnhancersthough it's not immediately clear where that issue lies. I could investigate this further but a couple facts:visTypeEnhancers. We may want to create a follow-up issue to just remove that codeThe simplest fix is to use
hacksrather thanvisTypeEnhancers, which works as expected:Basic license showing calls w/ license injected:
OSS show calls w/o license injected:
It's not entirely clear why one would use
hacksvs.visTypeEnhancersbut this use case appears to fit the general "hack guidelines" and I don't see the point of leveraging a separate type for this single, simple use case. With that said, I'm definitely open to pushback here.I also noticed an issue which can also be seen on master where the map appears blank on OSS past zoom level 10. This may have been resolved by #60942 since I didn't see the same behavior there. If not, we may want to create a separate issue for it.