[EPM] fix /packages response to return older packages #62623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neptunian
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/ingest-management (Feature:EPM) |
nchaulet
approved these changes
Apr 6, 2020
jfsiii
approved these changes
Apr 6, 2020
x-pack/plugins/ingest_manager/server/services/epm/packages/get.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Apr 6, 2020
* compare package list by name * use the internal property, adding as saved object attribute * remove HiddenPackages type
neptunian
added a commit
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixess #61679
The handler for
api/ingest_manager/epm/packagescompared against packages from the registry using the id which is{pkgName}-{version}. This caused packages that were not the latest version that were installed to not show up in the installed tab.Test:
POST an old version of nginx:
POST http://localhost:5603/ssg/api/ingest_manager/epm/packages/nginx-0.0.1
Go to installed packages and it should show up where before it was not