Skip to content

[Maps] Show create filter button for top-term tooltip property #62461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 8, 2020
Merged

[Maps] Show create filter button for top-term tooltip property #62461

merged 6 commits into from
Apr 8, 2020

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Apr 3, 2020

Fixes #60220

Screen Shot 2020-04-03 at 9 04 18 AM

@nreese nreese added release_note:enhancement Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.8.0 labels Apr 3, 2020
@nreese nreese requested a review from thomasneirynck April 3, 2020 15:08
@nreese nreese requested a review from a team as a code owner April 3, 2020 15:08
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 3, 2020

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Apr 3, 2020

@elasticmachine merge upstream

1 similar comment
@nreese
Copy link
Contributor Author

nreese commented Apr 6, 2020

@elasticmachine merge upstream

@nreese nreese force-pushed the top_terms_filter branch from 6270bdd to f856dae Compare April 6, 2020 20:23
@nreese
Copy link
Contributor Author

nreese commented Apr 7, 2020

@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little touch. Makes the filtering framework more full-featured.

x-pack/plugins/maps/public/layers/tooltips/es_agg_tooltip_property.ts Outdated
import { AGG_TYPE } from '../../../common/constants';
import { ITooltipProperty } from './tooltip_property';
import { IField } from '../fields/field';
import { IndexPattern } from '../../../../../../../src/plugins/data/public';
Copy link
Contributor

@thomasneirynck thomasneirynck Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewrite as import { IndexPattern } from 'src/plugins/data/public'; to make ts-linting happy.

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 8, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit bfdccfd into elastic:master Apr 8, 2020
nreese added a commit to nreese/kibana that referenced this pull request Apr 8, 2020
@nreese @elasticmachine
[Maps] Show create filter button for top-term tooltip property (elast…
3a3e306 
…ic#62461)

* [Maps] Show create filter button top-term tooltip property

* add missing imports

* update import for NP migration

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@nreese nreese mentioned this pull request Apr 8, 2020
Merged
nreese added a commit that referenced this pull request Apr 8, 2020
@nreese @elasticmachine
[Maps] Show create filter button for top-term tooltip property (#62461)…
b545619 
… (#62987)

* [Maps] Show create filter button top-term tooltip property

* add missing imports

* update import for NP migration

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 9, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into es_ui_shared/…
43763b0 
…chore/put-all-xjson-together

* 'master' of github.com:elastic/kibana: (35 commits)
  [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013)
  [SIEM][Detection Engine] Fix rule notification critical bugs
  Add Error Exception Type Column (elastic#59596)
  [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282)
  [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772)
  FTR: add chromium-based Edge browser support (elastic#61684)
  [Ingest] Data source configuration validation UI (elastic#61180)
  restore empty_kibana after saved objects test (elastic#62951)
  Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594)
  Add basic StatusService (elastic#60335)
  [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720)
  [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887)
  Exclude disabled datasources and streams from agent config (elastic#62869)
  [Alerting] Fix validation support for nested IErrorObjects (elastic#62833)
  [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837)
  Add --filter option to API docs script (elastic#62888)
  [Maps] fix attribution overflow with exit full screen button (elastic#62699)
  [Uptime]Alerting UI text in case filter is selected (elastic#62570)
  [Maps] Show create filter button for top-term tooltip property (elastic#62461)
  skip flaky suite (elastic#59030)
  ...

# Conflicts:
#	src/plugins/es_ui_shared/public/index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:enhancement Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.8.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Maps] Add keyword filter to top-term result in tooltip

4 participants

@nreese @elasticmachine @kibanamachine @thomasneirynck