Remove all client-side map munging #60701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smith
added
release_note:skip
sorenlouv
approved these changes
Mar 19, 2020
Member
sorenlouv
left a comment
sorenlouv
left a comment
There was a problem hiding this comment.
looks good. mostly stuff about constants. Thanks for doing this!
x-pack/legacy/plugins/apm/public/components/app/ServiceMap/Popover/Contents.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/apm/public/components/app/ServiceMap/Popover/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/apm/public/components/app/ServiceMap/cytoscapeOptions.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/apm/public/components/app/ServiceMap/cytoscapeOptions.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/apm/public/components/app/ServiceMap/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/apm/public/components/app/ServiceMap/icons.ts
Outdated
Show resolved
Hide resolved
smith
force-pushed
the
nls/no-munge
branch
3 times, most recently
from
dc762a8 to
ae59b52
Compare
sorenlouv
reviewed
Mar 20, 2020
x-pack/plugins/apm/server/lib/metrics/by_agent/java/thread_count/index.ts
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Mar 20, 2020
x-pack/legacy/plugins/apm/public/components/app/ServiceMap/index.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Mar 20, 2020
x-pack/legacy/plugins/apm/public/components/app/ServiceMap/index.tsx
Outdated
Show resolved
Hide resolved
smith
force-pushed
the
nls/no-munge
branch
3 times, most recently
from
613d4a3 to
0c8f93c
Compare
Remove the getCytoscapeElements function. On the server: * Replace `source` with `sourceData`, `destination` with `targetData`, `source.id` with `source`, and `destination.id` with `target`. * Return a single array as an `elements` property instead of `nodes` and `connections` * Map all of the items data to be inside of a `data` object * Replace SERVICE_AGENT_NAME with AGENT_NAME * Add some missing constants On the client: * Remove getCytoscapeElements * Move all presentation-specific data transformation to use the original attributes in the place where they're needed * Remove `href` since it wasn't being used * Move BetaBadge to its own file * Move cytoscapeDivStyle to cytoscapeOptions * Fix storybook to work with new data formats
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
smith
added a commit
to smith/kibana
that referenced
this pull request
Mar 22, 2020
Remove the getCytoscapeElements function. On the server: * Replace `source` with `sourceData`, `destination` with `targetData`, `source.id` with `source`, and `destination.id` with `target`. * Return a single array as an `elements` property instead of `nodes` and `connections` * Map all of the items data to be inside of a `data` object * Replace SERVICE_AGENT_NAME with AGENT_NAME * Add some missing constants On the client: * Remove getCytoscapeElements * Move all presentation-specific data transformation to use the original attributes in the place where they're needed * Remove `href` since it wasn't being used * Move BetaBadge to its own file * Move cytoscapeDivStyle to cytoscapeOptions * Fix storybook to work with new data formats
smith
added a commit
that referenced
this pull request
Mar 23, 2020
Remove the getCytoscapeElements function. On the server: * Replace `source` with `sourceData`, `destination` with `targetData`, `source.id` with `source`, and `destination.id` with `target`. * Return a single array as an `elements` property instead of `nodes` and `connections` * Map all of the items data to be inside of a `data` object * Replace SERVICE_AGENT_NAME with AGENT_NAME * Add some missing constants On the client: * Remove getCytoscapeElements * Move all presentation-specific data transformation to use the original attributes in the place where they're needed * Remove `href` since it wasn't being used * Move BetaBadge to its own file * Move cytoscapeDivStyle to cytoscapeOptions * Fix storybook to work with new data formats
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the getCytoscapeElements function.
On the server:
sourcewithsourceData,destinationwithtargetData,source.idwithsource, anddestination.idwithtarget.elementsproperty instead ofnodesandconnectionsdataobjectOn the client:
hrefsince it wasn't being used