[FTR] Add support for --include-file and --exclude-file #60123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
Team:Operations
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
|
Flaky failure is being tracked here: #60148 app arch team is fixing ASAP |
spalger
suggested changes
Mar 13, 2020
Contributor
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
Thank you so much for splitting this up, it would be a lot more difficult to provide feedback on these feature if they were mixed in with a bunch of other changes.
packages/kbn-test/src/functional_test_runner/lib/mocha/setup_mocha.js
Outdated
Show resolved
Hide resolved
packages/kbn-test/src/functional_test_runner/lib/mocha/decorate_mocha_ui.js
Outdated
Show resolved
Hide resolved
spalger
approved these changes
Mar 16, 2020
Contributor
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
LGTM, thanks for working me through the changes
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Mar 17, 2020
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Mar 17, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 17, 2020
* master: [SIEM] Adds 'Closes one signal when more than one opened signals are selected' test again (elastic#60380) [SIEM][Detections Engine] - Add rule markdown field to rule create, detail, and edit flows (elastic#60108) [Fleet] Add config revision to fleet agents (elastic#60292) Allow kbn-config-schema to ignore unknown keys (elastic#59560) [ML] Functional tests - disable df analytics clone tests skip flaky suite (elastic#58643) (elastic#58991) [FTR] Add support for --include and --exclude files via tags (elastic#60123) [SIEM] Fix link on overview page (elastic#60348) skip flaky test (elastic#60369) [Endpoint] Adds take action dropdown and tests to alert details flyout (elastic#59242) [Lens] Simplify state management from visualization (elastic#58279) Changing default type to start and allowing it to be configured by the event category (elastic#60323) [ML] Adds the class_assignment_objective to classification (elastic#60358)
brianseeders
added a commit
that referenced
this pull request
Mar 17, 2020
brianseeders
added a commit
that referenced
this pull request
Mar 17, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 17, 2020
* master: (51 commits) do not update cell background if is label cell (elastic#60308) FTR configurable test users (elastic#52431) [Reporting] Wholesale moves client to newest-platform (elastic#58945) [Ingest] Support `show_user` package registry flag (elastic#60338) [SIEM] Adds 'Closes one signal when more than one opened signals are selected' test again (elastic#60380) [SIEM][Detections Engine] - Add rule markdown field to rule create, detail, and edit flows (elastic#60108) [Fleet] Add config revision to fleet agents (elastic#60292) Allow kbn-config-schema to ignore unknown keys (elastic#59560) [ML] Functional tests - disable df analytics clone tests skip flaky suite (elastic#58643) (elastic#58991) [FTR] Add support for --include and --exclude files via tags (elastic#60123) [SIEM] Fix link on overview page (elastic#60348) skip flaky test (elastic#60369) [Endpoint] Adds take action dropdown and tests to alert details flyout (elastic#59242) [Lens] Simplify state management from visualization (elastic#58279) Changing default type to start and allowing it to be configured by the event category (elastic#60323) [ML] Adds the class_assignment_objective to classification (elastic#60358) [TSVB] fix text color when using custom background color (elastic#60261) Fix import to timefilter from in TSVB (elastic#60296) [NP] Get rid of usage redirectWhenMissing service (elastic#59777) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 17, 2020
* alerting/view-in-app: (53 commits) fixed typo handle optional alerting plugin do not update cell background if is label cell (elastic#60308) FTR configurable test users (elastic#52431) [Reporting] Wholesale moves client to newest-platform (elastic#58945) [Ingest] Support `show_user` package registry flag (elastic#60338) [SIEM] Adds 'Closes one signal when more than one opened signals are selected' test again (elastic#60380) [SIEM][Detections Engine] - Add rule markdown field to rule create, detail, and edit flows (elastic#60108) [Fleet] Add config revision to fleet agents (elastic#60292) Allow kbn-config-schema to ignore unknown keys (elastic#59560) [ML] Functional tests - disable df analytics clone tests skip flaky suite (elastic#58643) (elastic#58991) [FTR] Add support for --include and --exclude files via tags (elastic#60123) [SIEM] Fix link on overview page (elastic#60348) skip flaky test (elastic#60369) [Endpoint] Adds take action dropdown and tests to alert details flyout (elastic#59242) [Lens] Simplify state management from visualization (elastic#58279) Changing default type to start and allowing it to be configured by the event category (elastic#60323) [ML] Adds the class_assignment_objective to classification (elastic#60358) [TSVB] fix text color when using custom background color (elastic#60261) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separating this work from my "smaller test suites" branch.
This PR adds a unique tag to every functional test suite, equal to the relative path of the file in the kibana repo, e.g.
test/functional/apps/dashboard/empty_dashboard.jsThis tag/path can then be used with the new
--include-fileand--exclude-fileargs to easily target individual test files.The filtering is a separate step from the normal tag filtering, so that it ends up working in an
ANDfashion, rather thanOR.