[NP] Cutover ensureDefaultIndexPattern to kibana_utils #59895

sulemanof · 2020-03-11T13:50:12Z

Summary

A part of #58999

This moves ensureDefaultIndexPattern helper to kibana_utils, got rid of $rootScope & kbnUrl, uses history dependency instead.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

…n_missing # Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js # src/legacy/core_plugins/kibana/public/visualize/np_ready/legacy_app.js

…n_missing

…ana into shim/redirect_when_missing

…lt_index # Conflicts: # src/legacy/core_plugins/kibana/public/dashboard/np_ready/legacy_app.js # src/legacy/core_plugins/kibana/public/discover/kibana_services.ts # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js # src/legacy/core_plugins/kibana/public/visualize/np_ready/editor/editor.js # src/legacy/core_plugins/kibana/public/visualize/np_ready/legacy_app.js # src/plugins/kibana_utils/public/history/index.ts # src/plugins/kibana_utils/public/history/redirect_when_missing.tsx # src/plugins/kibana_utils/public/index.ts

elasticmachine · 2020-03-17T12:49:01Z

Pinging @elastic/kibana-app (Team:KibanaApp)

kertal

Code LGTM, tested locally in Chrome, was redirected to management

kertal · 2020-03-18T07:24:48Z

src/plugins/kibana_utils/public/history/ensure_default_index_pattern.tsx

 * resolve to wait for the URL change to happen.
 */
 export async function ensureDefaultIndexPattern(
  newPlatform: CoreStart,


Nit, could you rename newPlatformto core since we're already in NP?

yeah, makes sense !
Just was hesitant to rename it after Joe gave this name 😃

streamich

AppArch code changes LGTM.

…lt_index

kibanamachine · 2020-03-18T15:03:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: aa325e1

History

💚 Build #33776 succeeded aea8530
💔 Build #33747 failed 600dde6
💔 Build #32411 failed 8149cac

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Cutover ensure_default_index_pattern to kibana_utils * Fix conflicts * Proper name for argument Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: [NP] Cutover ensureDefaultIndexPattern to kibana_utils (elastic#59895) Closes elastic#60265. Adds Beta badge to service map (elastic#60482) [Visualize] Duplicated query filters in es request (elastic#60106) [ML] Disable functional transform tests Fixes to service map single node banner (elastic#60072) [Uptime] replace fetch with kibana http (elastic#59881) Upgrade @types/node to match Node.js runtime (elastic#60368)

lukeelmers · 2020-03-18T17:09:38Z

Since ensureDefaultIndexPattern is specific to index patterns, I wonder if longer-term it would make sense to eventually relocate this somewhere in data.indexPatterns or data.ui instead of in kibana_utils? That feels like it would be a more logical place for this, as index patterns feels like the clear owner of this functionality.
cc @lizozom @mattkime

…nless * 'app/painless' of github.com:elastic/kibana: (64 commits) Fix filter scope in bool query (#60488) change index pattern id to be the same as index pattern title (#60436) [Endpoint] resolver v1 events (#59233) Branding fixes for dashboard, loader and space selector (#60073) skip flaky suite (#60535) [SIEM][Detection Engine] Fixes bug with timeline templates not working Fixed errors which are happening if switch between alert types (#60453) [EPM] Add mapping field types to index template generation v2 (#60266) [NP] Cutover ensureDefaultIndexPattern to kibana_utils (#59895) Closes #60265. Adds Beta badge to service map (#60482) [Visualize] Duplicated query filters in es request (#60106) [ML] Disable functional transform tests Fixes to service map single node banner (#60072) [Uptime] replace fetch with kibana http (#59881) Upgrade @types/node to match Node.js runtime (#60368) [License Management] NP migration (#60250) Fix create alert button from not showing in alerts list (#60444) [SIEM][Case] Update connector through flyout (#60307) add data-test-subj where possible on SO management table (#60226) Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (#60406) ...

* Cutover ensure_default_index_pattern to kibana_utils * Fix conflicts * Proper name for argument Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* upstream/app/painless: (66 commits) Another i18n issue Fix i18n Fix filter scope in bool query (elastic#60488) change index pattern id to be the same as index pattern title (elastic#60436) [Endpoint] resolver v1 events (elastic#59233) Branding fixes for dashboard, loader and space selector (elastic#60073) skip flaky suite (elastic#60535) [SIEM][Detection Engine] Fixes bug with timeline templates not working Fixed errors which are happening if switch between alert types (elastic#60453) [EPM] Add mapping field types to index template generation v2 (elastic#60266) [NP] Cutover ensureDefaultIndexPattern to kibana_utils (elastic#59895) Closes elastic#60265. Adds Beta badge to service map (elastic#60482) [Visualize] Duplicated query filters in es request (elastic#60106) [ML] Disable functional transform tests Fixes to service map single node banner (elastic#60072) [Uptime] replace fetch with kibana http (elastic#59881) Upgrade @types/node to match Node.js runtime (elastic#60368) [License Management] NP migration (elastic#60250) Fix create alert button from not showing in alerts list (elastic#60444) [SIEM][Case] Update connector through flyout (elastic#60307) ...

sulemanof added 7 commits March 10, 2020 18:19

Move redirect_when_missing to kibana utils

ea33af6

Replace redirectWhenMissing in dashboard

ad3590a

Replace redirectWhenMissing in discover

d8ff50c

Merge remote-tracking branch 'upstream/master' into shim/redirect_whe…

80177fc

…n_missing # Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js # src/legacy/core_plugins/kibana/public/visualize/np_ready/legacy_app.js

Remove redirect in monitoring

0bdeb07

Remove extra import

1082371

Cutover ensure_default_index_pattern to kibana_utils

8149cac

sulemanof requested review from flash1293 and kertal March 11, 2020 13:52

elasticmachine and others added 5 commits March 11, 2020 12:21

Merge branch 'master' into shim/redirect_when_missing

dd752ce

Merge remote-tracking branch 'upstream/master' into shim/redirect_whe…

b46a44c

…n_missing

Move invalid vistype check into editor.js

2f8afe6

Merge branch 'shim/redirect_when_missing' of github.com:sulemanof/kib…

feb5af9

…ana into shim/redirect_when_missing

Merge branch 'shim/redirect_when_missing' into shim/ensure_default_index

2f29a51

sulemanof mentioned this pull request Mar 12, 2020

[NP] Remove kbnUrl usage in discover/dashboard/visualize #60016

Merged

7 tasks

sulemanof added 2 commits March 17, 2020 14:21

Fix conflicts

aea8530

sulemanof marked this pull request as ready for review March 17, 2020 12:48

sulemanof requested a review from a team March 17, 2020 12:48

sulemanof requested a review from a team as a code owner March 17, 2020 12:48

sulemanof added Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.7.0 v8.0.0 labels Mar 17, 2020

kertal approved these changes Mar 18, 2020

View reviewed changes

streamich approved these changes Mar 18, 2020

View reviewed changes

sulemanof added 2 commits March 18, 2020 16:17

Proper name for argument

a06df26

Merge remote-tracking branch 'upstream/master' into shim/ensure_defau…

aa325e1

…lt_index

sulemanof merged commit 965679a into elastic:master Mar 18, 2020

sulemanof deleted the shim/ensure_default_index branch March 18, 2020 15:28

sulemanof mentioned this pull request Mar 18, 2020

[7.x] [NP] Cutover ensureDefaultIndexPattern to kibana_utils (#59895) #60524

Merged

sulemanof added the backported label Mar 18, 2020

sulemanof mentioned this pull request Apr 9, 2020

Move ensureDefaultIndexPattern into data plugin #63100

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[NP] Cutover ensureDefaultIndexPattern to kibana_utils #59895

[NP] Cutover ensureDefaultIndexPattern to kibana_utils #59895

Uh oh!

sulemanof commented Mar 11, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Mar 17, 2020

Uh oh!

kertal left a comment

Uh oh!

kertal Mar 18, 2020

Uh oh!

sulemanof Mar 18, 2020

Uh oh!

streamich left a comment

Uh oh!

kibanamachine commented Mar 18, 2020

Uh oh!

lukeelmers commented Mar 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[NP] Cutover ensureDefaultIndexPattern to kibana_utils #59895

[NP] Cutover ensureDefaultIndexPattern to kibana_utils #59895

Uh oh!

Conversation

sulemanof commented Mar 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Mar 17, 2020

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

kertal Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

sulemanof Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

streamich left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 18, 2020

💚 Build Succeeded

History

Uh oh!

lukeelmers commented Mar 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sulemanof commented Mar 11, 2020 •

edited

Loading