Skip to content

Fix es_ui_shared eslint violations for useRequest hook #59626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Fix es_ui_shared eslint violations for useRequest hook #59626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4090ae1
Remove index_management and snapshot_restore from eslintrc.
cjcenizal Apr 24, 2020
41c0295
Reconcile request helpers with eslint rules for React hooks.
cjcenizal Mar 9, 2020
0b0a0de
Replace original request.ts with np_ready_request.ts.
cjcenizal Mar 11, 2020
616d4a6
Remove cleanup function which introduced a bug by setting isMounted t…
cjcenizal Apr 24, 2020
480c83d
Bring back isOutdatedRequest to gracefully handle changing poll inter…
cjcenizal Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,6 @@ module.exports = {
'jsx-a11y/click-events-have-key-events': 'off',
},
},
{
files: ['x-pack/legacy/plugins/index_management/**/*.{js,ts,tsx}'],
rules: {
'react-hooks/exhaustive-deps': 'off',
'react-hooks/rules-of-hooks': 'off',
},
},
{
files: ['x-pack/plugins/lens/**/*.{js,ts,tsx}'],
rules: {
Expand All @@ -121,12 +114,6 @@ module.exports = {
'react-hooks/exhaustive-deps': 'off',
},
},
{
files: ['x-pack/legacy/plugins/snapshot_restore/**/*.{js,ts,tsx}'],
rules: {
'react-hooks/exhaustive-deps': 'off',
},
},

/**
* Files that require Apache 2.0 headers, settings
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/es_ui_shared/public/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export {
UseRequestResponse,
sendRequest,
useRequest,
} from './request/np_ready_request';
} from './request/request';

export { indices } from './indices';

Expand Down
27 changes: 0 additions & 27 deletions src/plugins/es_ui_shared/public/request/index.ts
View file
Open in desktop

This file was deleted.

184 changes: 0 additions & 184 deletions src/plugins/es_ui_shared/public/request/np_ready_request.ts
View file
Open in desktop

This file was deleted.

Loading