Skip to content

Update misc dependencies #59542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 10, 2020
Merged

Update misc dependencies #59542

merged 6 commits into from
Mar 10, 2020

Conversation

@legrego
Copy link
Member

@legrego legrego commented Mar 6, 2020

Summary

@legrego legrego added v7.6.2 v7.7.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 6, 2020
@legrego
Copy link
Member Author

legrego commented Mar 6, 2020

@elasticmachine merge upstream

@legrego legrego added the chore label Mar 6, 2020
@legrego legrego requested a review from jportner March 6, 2020 16:42
jportner
jportner reviewed Mar 6, 2020
View reviewed changes
jportner
jportner reviewed Mar 6, 2020
View reviewed changes
@legrego
Copy link
Member Author

legrego commented Mar 6, 2020

Sorry, I should have elaborated more on my research. You're right that less is an actual dependency. We use it within the TSVB visualization when rendering markdown. I verified this still works as intended, and the breaking changes listed don't appear to impact us:

image

It looks like the latest version of good-squeeze is 5.1.0, and that was published over two years ago. It appears this is deprecated in favor of @hapi/good-squeeze.
Did you check and see if we might be able to upgrade to that instead?
Also, since this is a non-dev dependency, did you look and see if the change from 2.x to 5.x might break anything?

I wasn't aware of this change, thanks for pointing that out. I'll research and see if we can update to 5.1.0

@legrego legrego requested a review from a team as a code owner March 6, 2020 19:46
@legrego
Copy link
Member Author

legrego commented Mar 6, 2020

Looks like we can update to @hapi/good-squeeze 5.2.1. There are two breaking changes along the way, but neither of them impact us, based on my testing.

jportner
jportner reviewed Mar 6, 2020
View reviewed changes
yarn.lock Outdated
Comment on lines 13584 to 13592
fast-safe-stringify@2.x.x, fast-safe-stringify@^2.0.7:
version "2.0.7"
resolved "https://registry.yarnpkg.com/fast-safe-stringify/-/fast-safe-stringify-2.0.7.tgz#124aa885899261f68aedb42a7c080de9da608743"
integrity sha512-Utm6CdzT+6xsDk2m8S6uL8VHxNwI6Jub+e9NYTcAms28T84pTa25GJQV9j0CY0N1rM8hK4x6grpF2BQf+2qwVA==

fast-safe-stringify@^2.0.4:
version "2.0.6"
resolved "https://registry.yarnpkg.com/fast-safe-stringify/-/fast-safe-stringify-2.0.6.tgz#04b26106cc56681f51a044cfc0d76cf0008ac2c2"
integrity sha512-q8BZ89jjc+mz08rSxROs8VsrBBcn1SIw1kq9NjolL509tkABRk9io01RAjSaEv1Xb2uFLt8VtRiZbGp5H8iDtg==
Copy link
Contributor

@jportner jportner Mar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fast-safe-stringify@2.x.x, fast-safe-stringify@^2.0.7:
version "2.0.7"
resolved "https://registry.yarnpkg.com/fast-safe-stringify/-/fast-safe-stringify-2.0.7.tgz#124aa885899261f68aedb42a7c080de9da608743"
integrity sha512-Utm6CdzT+6xsDk2m8S6uL8VHxNwI6Jub+e9NYTcAms28T84pTa25GJQV9j0CY0N1rM8hK4x6grpF2BQf+2qwVA==
fast-safe-stringify@^2.0.4:
version "2.0.6"
resolved "https://registry.yarnpkg.com/fast-safe-stringify/-/fast-safe-stringify-2.0.6.tgz#04b26106cc56681f51a044cfc0d76cf0008ac2c2"
integrity sha512-q8BZ89jjc+mz08rSxROs8VsrBBcn1SIw1kq9NjolL509tkABRk9io01RAjSaEv1Xb2uFLt8VtRiZbGp5H8iDtg==
fast-safe-stringify@2.x.x, fast-safe-stringify@^2.0.4, fast-safe-stringify@^2.0.7:
version "2.0.7"
resolved "https://registry.yarnpkg.com/fast-safe-stringify/-/fast-safe-stringify-2.0.7.tgz#124aa885899261f68aedb42a7c080de9da608743"
integrity sha512-Utm6CdzT+6xsDk2m8S6uL8VHxNwI6Jub+e9NYTcAms28T84pTa25GJQV9j0CY0N1rM8hK4x6grpF2BQf+2qwVA==

Looks like we could combine these two transitive dependencies, too!

Copy link
Member Author

@legrego legrego Mar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - times like this make me wish yarn was more aggressive about consolidating its own lockfile.

@legrego legrego removed the v7.6.2 label Mar 9, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 9, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jportner
jportner approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legrego legrego merged commit 914df79 into elastic:master Mar 10, 2020
@legrego legrego deleted the chore/update-deps branch March 10, 2020 12:19
@legrego legrego mentioned this pull request Mar 10, 2020
Merged
legrego added a commit to legrego/kibana that referenced this pull request Mar 10, 2020
@legrego @elasticmachine
Update misc dependencies (elastic#59542)
6b3e52a 
* update deps

* updating to @hapi/good-squeeze

* consolidate fast-safe-stringify deps

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Mar 10, 2020
@legrego @elasticmachine
Update misc dependencies (#59542) (#59741)
24c33e2 
* update deps

* updating to @hapi/good-squeeze

* consolidate fast-safe-stringify deps

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 10, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
dd5ae27 
* master:
  Add a retry to dashboard test for a sometimes slow async operation (elastic#59600)
  [Endpoint] Sample data generator for endpoint app (elastic#58936)
  [Vis Editor] Refactoring metrics axes (elastic#59135)
  [DOCS] Changed Discover app to Discover (elastic#59769)
  [Metrics Alerts] Add support for search query and groupBy on alerts (elastic#59388)
  Enhancement - EUICodeEditor for Visualize JSON  (elastic#58679)
  [ML] Transforms: Data grid fixes. (elastic#59538)
  [SIEM] Fix and consolidate handling of error responses in the client (elastic#59438)
  [Maps] convert tooltip classes to typescript (elastic#59589)
  [ML] Functional tests - re-activate date_nanos test (elastic#59649)
  Move canvas to use NP Expressions service (elastic#58387)
  Update misc dependencies (elastic#59542)
  [Unit Testing] Configure react-testing-library queries to use Kibana's data-test-subj instead of default data-testid (elastic#59445)
  [Console] Remove unused code (elastic#59554)
  [Logs / Metrics UI] Link handling / stop page reloads (elastic#58478)
  Add SavedObject management section registration in core  (elastic#59291)
@wylieconlon wylieconlon mentioned this pull request Mar 10, 2020
Merged
7 tasks
@wylieconlon
Copy link
Contributor

wylieconlon commented Mar 10, 2020

Please revert the upgrade to less, as it breaks IE11 compatibility

@legrego legrego mentioned this pull request Mar 11, 2020
Merged
@legrego
Copy link
Member Author

legrego commented Mar 11, 2020

Reverting: #59852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

+1 more reviewer

@jportner jportner jportner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@legrego @kibanamachine @wylieconlon @pgayvallet @jportner @elasticmachine