Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.6] [SIEM] Default the Timeline events filter to show All events (#58953) #59059

Merged
merged 3 commits into from
Mar 3, 2020
Merged

[7.6] [SIEM] Default the Timeline events filter to show All events (#58953) #59059

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7febd7
[SIEM] Default the Timeline events filter to show All events (#58953)
andrew-goldstein Mar 2, 2020
b5ddab4
Merge branch '7.6' of github.com:elastic/kibana into backport/7.6/pr-…
andrew-goldstein Mar 3, 2020
1ad7971
* Added `eventType`, which is a required prop in `7.6.x` to pass the …
andrew-goldstein Mar 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
* Added eventType, which is a required prop in 7.6.x to pass the … 
…type check, along with this note:

```
CAUTION: `eventType` is an optional prop in post-`7.6.x` branches. In later branches, `eventType`
is omitted from this test, to truly verify the new default from redux. In this branch, we must
specify `eventType` to pass the type check, but this is not the true intent of this test.
```
  • Loading branch information
@andrew-goldstein
andrew-goldstein committed Mar 3, 2020
commit 1ad79719aa8d71c533aaa716075231296ca7c097
1 change: 1 addition & 0 deletions x-pack/legacy/plugins/siem/public/components/timeline/timeline.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ describe('Timeline', () => {
id="foo"
dataProviders={mockDataProviders}
end={endDate}
eventType="all" // CAUTION: `eventType` is an optional prop in post-`7.6.x` branches. In later branches, `eventType` is omitted from this test, to truly verify the new default from redux. In this branch, we must specify `eventType` to pass the type check, but this is not the true intent of this test.
filters={[]}
flyoutHeight={testFlyoutHeight}
flyoutHeaderHeight={flyoutHeaderHeight}
Expand Down