Skip to content

Conversation

@streamich
Copy link
Contributor

@streamich streamich commented Feb 25, 2020

Summary

  • Adds ability to embeddable to report what triggers it executes through .supportedTriggers() method.
  • Adds to VisualizationEmbeddable an implementation of .supportedTriggers() method.

Dev Docs

Embeddables can now report ui_actions triggers that they execute through .supportedTriggers() method. For example:

class MyEmbeddable extends Embeddable {
  supportedTriggers() {
    return ['VALUE_CLICK_TRIGGER'];
  }
}

The returned list of triggers will be used in drilldowns feature on Dashboard, where user will be able to add drilldowns to embeddable triggers.

@streamich streamich requested a review from a team as a code owner February 25, 2020 09:59
@streamich streamich added Feature:Actions Feature:Embedding Embedding content via iFrame release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. review Team:AppArch v7.7.0 v8.0.0 labels Feb 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich mentioned this pull request Mar 6, 2020
9 tasks
Copy link
Contributor

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@streamich streamich merged commit 92aec69 into elastic:master Mar 16, 2020
streamich added a commit that referenced this pull request Mar 17, 2020
* feat: 🎸 add Embeddable.supportedTriggers() method

* feat: 🎸 report supported triggers on visualization embeddable

* feat: 🎸 hard-code supportedTriggers() in visualize_embed

* feat: 🎸 use VIS_EVENT_TO_TRIGGER when executing trigger

* perf: ⚡️ improve type

* fix: 🐛 revert back trigger check to how it is done on master

* chore: 🤖 remove unused import

* feat: 🎸 hard-code triggers for each visualization

* fix: 🐛 fix import

* feat: 🎸 reshuffle vis_types in supportedTriggers() method

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 17, 2020
* master: (30 commits)
  [TSVB] fix text color when using custom background color (elastic#60261)
  Fix import to timefilter from in TSVB (elastic#60296)
  [NP] Get rid of usage redirectWhenMissing service (elastic#59777)
  [SIEM] Fix Timeline footer styling (elastic#59587)
  [ML] Fixes to error handling for analytics jobs and file data viz (elastic#60249)
  Give better stack traces for Unhandled Promise Rejection warnings (elastic#60235)
  resolves elastic#58905 (elastic#60120)
  Added variables button for text fields in Pagerduty component. (elastic#60189)
  adds test that action vars are rendered for alert action parms (elastic#60310)
  Closes 59786 by removing the update toast (elastic#60172)
  [EPM] Packages list tabs (elastic#60167)
  Added message variables button for Webhook body form field (elastic#60174)
  Revert "adds new test (elastic#60064)"
  [Maps] move MapSavedObject type out of telemetry (elastic#60127)
  [Reporting] Fix error handling for job handler in route (elastic#60161)
  [Endpoint] TEST: verify alerts page header says 'Alerts' (elastic#60206)
  EMT-248: implement ack resource to accept event payload to acknowledge agent actions (elastic#60218)
  Migrate dual validated range (elastic#59689)
  Embeddable triggers (elastic#58440)
  [Endpoint] Sample data generator CLI script (elastic#59952)
  ...
@kibanamachine
Copy link
Contributor

💔 Build Failed


Test Failures

Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_errors·js.discover app errors invalid scripted field error is rendered

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://dryrun

[00:00:00]       │
[00:01:42]         └-: discover app
[00:01:42]           └-> "before all" hook
[00:01:42]           └-> "before all" hook
[00:09:35]           └-: errors
[00:09:35]             └-> "before all" hook
[00:09:35]             └-> "before all" hook
[00:09:35]               │ info [logstash_functional] Loading "mappings.json"
[00:09:35]               │ info [logstash_functional] Loading "data.json.gz"
[00:09:35]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:09:35]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:09:35]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:09:36]               │ info [invalid_scripted_field] Loading "mappings.json"
[00:09:36]               │ info [invalid_scripted_field] Loading "data.json.gz"
[00:09:36]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_2/RTxmblVcTFWcu4RtX16EcQ] deleting index
[00:09:36]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_1/6ZQzOBjuS3uz0716Hj1WlA] deleting index
[00:09:36]               │ info [invalid_scripted_field] Deleted existing index [".kibana_2",".kibana_1"]
[00:09:36]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] applying create index request using v1 templates []
[00:09:36]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:09:36]               │ info [invalid_scripted_field] Created index ".kibana"
[00:09:36]               │ debg [invalid_scripted_field] ".kibana" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:09:36]               │ info [invalid_scripted_field] Indexed 2 docs into ".kibana"
[00:09:36]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana/c449Tp_tSxapg5OFTfXAaQ] update_mapping [_doc]
[00:09:36]               │ debg Migrating saved objects
[00:09:36]               │ proc [kibana]   log   [17:10:37.898] [info][savedobjects-service] Creating index .kibana_2.
[00:09:36]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] applying create index request using v1 templates []
[00:09:36]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:09:36]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] updating number_of_replicas to [0] for indices [.kibana_2]
[00:09:36]               │ proc [kibana]   log   [17:10:37.938] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:09:36]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] applying create index request using v1 templates []
[00:09:36]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:09:36]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] updating number_of_replicas to [0] for indices [.kibana_1]
[00:09:36]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] 8382 finished with response BulkByScrollResponse[took=14.4ms,timed_out=false,sliceId=null,updated=0,created=2,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:09:36]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana/c449Tp_tSxapg5OFTfXAaQ] deleting index
[00:09:36]               │ proc [kibana]   log   [17:10:38.248] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:09:36]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_2/JmgzV04qSJmG5ypyZ4sgQg] update_mapping [_doc]
[00:09:36]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_2/JmgzV04qSJmG5ypyZ4sgQg] update_mapping [_doc]
[00:09:36]               │ proc [kibana]   log   [17:10:38.296] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:09:36]               │ proc [kibana]   log   [17:10:38.319] [info][savedobjects-service] Finished in 423ms.
[00:09:36]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:09:37]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_2/JmgzV04qSJmG5ypyZ4sgQg] update_mapping [_doc]
[00:09:38]               │ debg navigating to discover url: http://localhost:6161/app/kibana#/discover
[00:09:38]               │ debg Navigate to: http://localhost:6161/app/kibana#/discover
[00:09:38]               │ debg ... sleep(700) start
[00:09:38]               │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1586538639944#/discover 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:38]               │
[00:09:38]               │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:39]               │ debg ... sleep(700) end
[00:09:39]               │ debg returned from get, calling refresh
[00:09:39]               │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1586538639944#/discover 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:39]               │
[00:09:39]               │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:39]               │ debg currentUrl = http://localhost:6161/app/kibana#/discover
[00:09:39]               │          appUrl = http://localhost:6161/app/kibana#/discover
[00:09:39]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:42]               │ debg TestSubjects.find(kibanaChrome)
[00:09:42]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:09:42]               │ debg browser[INFO] http://localhost:6161/bundles/plugin/data/data.plugin.js 96:139970 "INFO: 2020-04-10T17:10:43Z
[00:09:42]               │        Adding connection to http://localhost:6161/elasticsearch
[00:09:42]               │
[00:09:42]               │      "
[00:09:42]               │ debg ... sleep(501) start
[00:09:42]               │ debg ... sleep(501) end
[00:09:42]               │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%2718ea0c30-2d77-11e8-93f2-6f8a391f33ef%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:09:42]               │ debg --- retry.try error: URL changed, waiting for it to settle
[00:09:43]               │ debg ... sleep(501) start
[00:09:43]               │ debg ... sleep(501) end
[00:09:43]               │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%2718ea0c30-2d77-11e8-93f2-6f8a391f33ef%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:09:43]               │ debg TestSubjects.exists(statusPageContainer)
[00:09:43]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:09:46]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:09:46]             └-: invalid scripted field error
[00:09:46]               └-> "before all" hook
[00:09:46]               └-> is rendered
[00:09:46]                 └-> "before each" hook: global before each
[00:09:46]                 │ debg TestSubjects.exists(discoverFetchError)
[00:09:46]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="discoverFetchError"]') with timeout=2500
[00:09:49]                 │ debg --- retry.tryForTime error: [data-test-subj="discoverFetchError"] is not displayed
[00:09:49]                 │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/discover app errors invalid scripted field error is rendered.png"
[00:09:50]                 │ info Current URL is: http://localhost:6161/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%2718ea0c30-2d77-11e8-93f2-6f8a391f33ef%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:09:50]                 │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/discover app errors invalid scripted field error is rendered.html
[00:09:50]                 └- ✖ fail: "discover app errors invalid scripted field error is rendered"
[00:09:50]                 │

Stack Trace

Error: expected false to equal true
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (packages/kbn-expect/expect.js:227:8)
    at Assertion.be (packages/kbn-expect/expect.js:69:22)
    at Context.it (test/functional/apps/discover/_errors.js:41:40)

Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_errors·js.discover app errors invalid scripted field error is rendered

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:01:46]         └-: discover app
[00:01:46]           └-> "before all" hook
[00:01:46]           └-> "before all" hook
[00:09:58]           └-: errors
[00:09:58]             └-> "before all" hook
[00:09:58]             └-> "before all" hook
[00:09:58]               │ info [logstash_functional] Loading "mappings.json"
[00:09:58]               │ info [logstash_functional] Loading "data.json.gz"
[00:09:58]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:09:58]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:09:58]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:09:59]               │ info [invalid_scripted_field] Loading "mappings.json"
[00:09:59]               │ info [invalid_scripted_field] Loading "data.json.gz"
[00:09:59]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_2/4dnEVwQkRkq25iaKUX3yPg] deleting index
[00:09:59]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_1/0q8t_x6sQxe2D-zCdI3cEQ] deleting index
[00:09:59]               │ info [invalid_scripted_field] Deleted existing index [".kibana_2",".kibana_1"]
[00:09:59]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] applying create index request using v1 templates []
[00:09:59]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:10:00]               │ info [invalid_scripted_field] Created index ".kibana"
[00:10:00]               │ debg [invalid_scripted_field] ".kibana" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:10:00]               │ info [invalid_scripted_field] Indexed 2 docs into ".kibana"
[00:10:00]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana/mBH4LzvfRqGJybdXfJtrYA] update_mapping [_doc]
[00:10:00]               │ debg Migrating saved objects
[00:10:00]               │ proc [kibana]   log   [16:59:00.858] [info][savedobjects-service] Creating index .kibana_2.
[00:10:00]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] applying create index request using v1 templates []
[00:10:00]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:10:00]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] updating number_of_replicas to [0] for indices [.kibana_2]
[00:10:00]               │ proc [kibana]   log   [16:59:00.921] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:10:00]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] applying create index request using v1 templates []
[00:10:00]               │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:10:00]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] updating number_of_replicas to [0] for indices [.kibana_1]
[00:10:00]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] 8453 finished with response BulkByScrollResponse[took=21.9ms,timed_out=false,sliceId=null,updated=0,created=2,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:10:00]               │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana/mBH4LzvfRqGJybdXfJtrYA] deleting index
[00:10:00]               │ proc [kibana]   log   [16:59:01.265] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:10:00]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_2/EHb-k1C5RyqyDVpP3hhR2A] update_mapping [_doc]
[00:10:00]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_2/EHb-k1C5RyqyDVpP3hhR2A] update_mapping [_doc]
[00:10:00]               │ proc [kibana]   log   [16:59:01.326] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:10:00]               │ proc [kibana]   log   [16:59:01.372] [info][savedobjects-service] Finished in 516ms.
[00:10:00]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:10:01]               │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-oraclelinux-tests-xl-1586536189148059603] [.kibana_2/EHb-k1C5RyqyDVpP3hhR2A] update_mapping [_doc]
[00:10:02]               │ debg navigating to discover url: http://localhost:6161/app/kibana#/discover
[00:10:02]               │ debg Navigate to: http://localhost:6161/app/kibana#/discover
[00:10:02]               │ debg ... sleep(700) start
[00:10:02]               │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1586537942923#/discover 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:10:02]               │
[00:10:02]               │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:10:02]               │ debg ... sleep(700) end
[00:10:02]               │ debg returned from get, calling refresh
[00:10:03]               │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1586537942923#/discover 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:10:03]               │
[00:10:03]               │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:10:03]               │ debg currentUrl = http://localhost:6161/app/kibana#/discover
[00:10:03]               │          appUrl = http://localhost:6161/app/kibana#/discover
[00:10:03]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:10:06]               │ debg TestSubjects.find(kibanaChrome)
[00:10:06]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:10:06]               │ debg browser[INFO] http://localhost:6161/bundles/plugin/data/data.plugin.js 96:139970 "INFO: 2020-04-10T16:59:06Z
[00:10:06]               │        Adding connection to http://localhost:6161/elasticsearch
[00:10:06]               │
[00:10:06]               │      "
[00:10:06]               │ debg ... sleep(501) start
[00:10:07]               │ debg ... sleep(501) end
[00:10:07]               │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%2718ea0c30-2d77-11e8-93f2-6f8a391f33ef%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:10:07]               │ debg --- retry.try error: URL changed, waiting for it to settle
[00:10:07]               │ debg ... sleep(501) start
[00:10:08]               │ debg ... sleep(501) end
[00:10:08]               │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%2718ea0c30-2d77-11e8-93f2-6f8a391f33ef%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:10:08]               │ debg TestSubjects.exists(statusPageContainer)
[00:10:08]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:10:10]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:10:11]             └-: invalid scripted field error
[00:10:11]               └-> "before all" hook
[00:10:11]               └-> is rendered
[00:10:11]                 └-> "before each" hook: global before each
[00:10:11]                 │ debg TestSubjects.exists(discoverFetchError)
[00:10:11]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="discoverFetchError"]') with timeout=2500
[00:10:13]                 │ debg --- retry.tryForTime error: [data-test-subj="discoverFetchError"] is not displayed
[00:10:14]                 │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/discover app errors invalid scripted field error is rendered.png"
[00:10:14]                 │ info Current URL is: http://localhost:6161/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%2718ea0c30-2d77-11e8-93f2-6f8a391f33ef%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:10:14]                 │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/discover app errors invalid scripted field error is rendered.html
[00:10:14]                 └- ✖ fail: "discover app errors invalid scripted field error is rendered"
[00:10:14]                 │

Stack Trace

Error: expected false to equal true
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (packages/kbn-expect/expect.js:227:8)
    at Assertion.be (packages/kbn-expect/expect.js:69:22)
    at Context.it (test/functional/apps/discover/_errors.js:41:40)

Kibana Pipeline / kibana-intake-agent / Jest Integration Tests.packages/kbn-plugin-generator/integration_tests.running the plugin-generator via 'node scripts/generate_plugin.js plugin-name' with default config then running with es instance 'yarn start' should result in the spec plugin being initialized on kibana's stdout

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 4 times on tracked branches: https://github.com/elastic/kibana/issues/54481


Stack Trace

Error: Command failed with exit code 126: ./bin/elasticsearch-keystore create
    at makeError (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/execa/lib/error.js:56:11)
    at handlePromise (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/execa/index.js:114:26)
    at process._tickCallback (internal/process/next_tick.js:68:7)

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Actions Feature:Embedding Embedding content via iFrame release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. review v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants