Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard a11y tests #58122

Merged
merged 15 commits into from
Mar 2, 2020
Merged

Dashboard a11y tests #58122

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d99cb06
adding comprehensive dashboard tests
bhavyarm Feb 17, 2020
924fc62
fixing delete and adding dima changes
bhavyarm Feb 19, 2020
06a7eea
Fixing some of the a11y test failures
Feb 20, 2020
ed518fe
Fixing i18n issue
Feb 20, 2020
f29d5b3
Extracting exit fullscreen logic in a separate function
Feb 20, 2020
37b6bdb
Fixing typo
Feb 20, 2020
3520d1b
Upgrading axe
Feb 21, 2020
c998cec
Fixing failing jest tests
Feb 21, 2020
4be666b
Removing main tag as it was causing a test to fail
Feb 21, 2020
d67877b
Adding focusable=false to a range control as well
Feb 21, 2020
154a40c
Update test/accessibility/apps/dashboard.ts
Feb 27, 2020
1976b66
Fixing linting error
Feb 27, 2020
59fd20f
Update src/legacy/core_plugins/input_control_vis/public/components/vi…
Mar 2, 2020
919221b
Add comments
Mar 2, 2020
f9224cd
Merge branch 'master' into pr/57821
elasticmachine Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding focusable=false to a range control as well
  • Loading branch information
Maja Grubic committed Mar 2, 2020
commit d67877bbf84a85a4011f2e5d094e331044889076
1 change: 1 addition & 0 deletions src/legacy/ui/public/validated_range/validated_dual_range.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ export class ValidatedDualRange extends Component {
fullWidth={fullWidth}
value={this.state.value}
onChange={this._onChange}
focusable={false}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment above to make focusable again when #59039 is fixed

{...rest}
/>
</EuiFormRow>
Expand Down