Skip to content

[Uptime] Add default chart empty state #57725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 3, 2020
Merged

[Uptime] Add default chart empty state #57725

merged 7 commits into from
Mar 3, 2020

Conversation

@justinkambic
Copy link
Contributor

@justinkambic justinkambic commented Feb 14, 2020

Summary

Resolves #55214

Adds a reusable empty state that components can render instead of a chart when the requisite data is missing.

Testing this PR

Run this patch, and navigate to the Monitors page and set the date range to a time when there are no pings. You should observe a shared empty prompt like the one below, vs. the one in the linked issue:

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@justinkambic justinkambic added v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 14, 2020
@justinkambic justinkambic self-assigned this Feb 14, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 14, 2020

Pinging @elastic/uptime (Team:uptime)

@justinkambic justinkambic force-pushed the uptime_shared-chart-empty-state branch from a7cbc22 to 537d86c Compare February 18, 2020 14:40
shahzad31
shahzad31 approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@justinkambic
Copy link
Contributor Author

justinkambic commented Feb 25, 2020

@elasticmachine merge upstream

@justinkambic
Copy link
Contributor Author

justinkambic commented Feb 25, 2020

@elasticmachine merge upstream

@justinkambic
Copy link
Contributor Author

justinkambic commented Feb 27, 2020

@elasticmachine merge upstream

@justinkambic
Copy link
Contributor Author

justinkambic commented Feb 28, 2020

@elasticmachine merge upstream

@justinkambic
Copy link
Contributor Author

justinkambic commented Mar 2, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 2, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@justinkambic justinkambic merged commit bfca202 into elastic:master Mar 3, 2020
@justinkambic justinkambic mentioned this pull request Mar 3, 2020
Merged
justinkambic added a commit that referenced this pull request Mar 3, 2020
@justinkambic @elasticmachine
[Uptime] Add default chart empty state (#57725) (#59137)
95cf5f9 
* Add default chart empty state.

* Delete obsolete translations.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@justinkambic
Copy link
Contributor Author

justinkambic commented Mar 3, 2020

Backported to:
7.x/7.7.0 95cf5f9
#59137

@justinkambic justinkambic deleted the uptime_shared-chart-empty-state branch March 3, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees

@justinkambic justinkambic

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Uptime] Monitor charts should display visually similar empty data state messages

4 participants

@justinkambic @elasticmachine @kibanamachine @shahzad31