[Remote clusters] Migrate client-side code out of legacy #57365

alisonelizabeth · 2020-02-11T19:22:39Z

This PR mostly completes the NP migration for the remote_clusters plugin.

Continuation of #56781.

What's left

Once the index_management plugin is fully migrated, it should be a required plugin for remote_clusters
Once CCR is migrated, the legacy config should be removed from remote_clusters

How to test

You will need to set up two clusters in order to test remote clusters. For example:

yarn es snapshot
yarn es snapshot -E cluster.name="my_cluster" -E http.port=9201 -E path.data=/tmp/es (in another tab)

Test all actions behave as expected (create, edit, delete remote clusters)
Test integration and redirect behavior with CCR (e.g., if you create a remote cluster from the CCR flow, you should be redirected back to CCR)
Confirm remote clusters is disabled if xpack.remote_clusters.enabled is false
Test error handling (e.g., create a cluster with the same name as an existing one)

elasticmachine · 2020-02-11T19:22:43Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

…sters

alisonelizabeth · 2020-02-13T17:07:21Z

x-pack/plugins/remote_clusters/__jest__/client_integration/remote_clusters_add.test.js

@@ -77,7 +77,7 @@ describe('Create Remote cluster', () => {
      beforeEach(async () => {
        ({ component, form, actions } = setup());

-        await nextTick();
+        await nextTick(100);


I needed to adjust the timeout when switching from axios to the http service

Was the issue the same in each instance where nextTick was added? Just wondering whether it is worth putting a comment in each time.

Not a big deal though :)

Good point! I may have gotten carried away 😂. It actually is not needed for this specific line, but I updated the code where it was needed with a comment.

sebelga · 2020-02-14T10:06:56Z

x-pack/plugins/remote_clusters/public/plugin.ts

+        } = core;
+
+        // Initialize services
+        initBreadcrumbs(setBreadcrumbs);


@jloleysens This is the type of convention I was trying to get to. In my apps I am migrating I am instantiating the service inside the plugin setup() cycle.

👍 I guess in this pattern we would also not want the stateful services to be accessed via import in downstream code (as it currently is), e.g.,

kibana/x-pack/plugins/remote_clusters/public/application/services/breadcrumb.ts

Line 21 in 1a41c84

let _setBreadcrumbs: (breadcrumbs: Breadcrumb[]) => void;

More asking 👆🏻 :)

Correct, these are still being accessed via import. I was on the fence to whether it made sense to refactor as part of this migration PR. I think it might be better to open up a separate PR once this is merged and move to context if that is the pattern we want to follow.

jloleysens

These changes look great to me! Always good to see a PR that is "in the red" 😉

Left a question regarding tests, not a blocker.

jloleysens · 2020-02-14T12:14:38Z

x-pack/plugins/remote_clusters/__jest__/client_integration/remote_clusters_add.test.js

@@ -77,7 +77,7 @@ describe('Create Remote cluster', () => {
      beforeEach(async () => {
        ({ component, form, actions } = setup());

-        await nextTick();
+        await nextTick(100);


Was the issue the same in each instance where nextTick was added? Just wondering whether it is worth putting a comment in each time.

Not a big deal though :)

…sters

kibanamachine · 2020-02-14T22:13:42Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 88fc9a1

History

💚 Build #26906 succeeded ecc2bd0
💚 Build #26579 succeeded 1a41c84
💔 Build #26567 failed e98718e
💚 Build #26328 succeeded 58b03ed
💔 Build #26298 failed 87909a2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

… (#57747)

…re/files-and-filetree * 'master' of github.com:elastic/kibana: (139 commits) Move Ace XJSON lexer-rules, worker and utils to es_ui_shared (elastic#57563) [Upgrade Assistant] Fix filter deprecations search filter (elastic#57541) [ML] New Platform server shim: update indices routes (elastic#57685) Bump redux dependencies (elastic#53348) [Index management] Client-side NP ready (elastic#57295) change id of x-pack event_log plugin to eventLog (elastic#57612) [eventLog] get kibana.index name from config instead of hard-coding it (elastic#57607) revert allow using any path to generate fixes ui titles (elastic#57535) Fix login redirect for expired sessions (elastic#57157) Expose Vis on the contract as it requires visTypes (elastic#56968) [SIEM][Detection Engine] Fixes queries to ignore errors when signals index is not present [Remote clusters] Migrate client-side code out of legacy (elastic#57365) Fix failed test reporter for SIEM Cypress use (elastic#57240) skip flaky suite (elastic#45244) update chromedriver to 80.0.1 (elastic#57602) change slack action to only report on whitelisted host name (elastic#57582) [kbn/optimizer] throw errors into stream on invalid completion (elastic#57735) moving visualize/utils to new platform (elastic#56650) ...

alisonelizabeth added 2 commits February 11, 2020 11:51

adopt NP services

6cf928b

move code out of legacy

f429fe4

alisonelizabeth added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.7.0 labels Feb 11, 2020

alisonelizabeth added 8 commits February 11, 2020 15:46

fix redirect logic

b15db5c

fix error handling

fe16bae

Merge branch 'master' of github.com:elastic/kibana into np/remote_clu…

97f9f7c

…sters

clean up TS

87909a2

update tests

58b03ed

add config support

2350b18

rename app directory to application

e98718e

fix paths

1a41c84

alisonelizabeth commented Feb 13, 2020

View reviewed changes

alisonelizabeth mentioned this pull request Feb 13, 2020

[Index management] Client-side NP ready #57295

Merged

alisonelizabeth marked this pull request as ready for review February 13, 2020 17:18

alisonelizabeth requested a review from jloleysens February 13, 2020 18:47

sebelga reviewed Feb 14, 2020

View reviewed changes

jloleysens approved these changes Feb 14, 2020

View reviewed changes

alisonelizabeth added 3 commits February 14, 2020 12:07

Merge branch 'master' of github.com:elastic/kibana into np/remote_clu…

a6d138e

…sters

update tests

ecc2bd0

Merge branch 'master' of github.com:elastic/kibana into np/remote_clu…

88fc9a1

…sters

alisonelizabeth merged commit 6e37905 into elastic:master Feb 15, 2020

alisonelizabeth deleted the np/remote_clusters branch February 15, 2020 02:10

alisonelizabeth mentioned this pull request Feb 15, 2020

[7.x] [Remote clusters] Migrate client-side code out of legacy (#57365) #57747

Merged

alisonelizabeth added a commit that referenced this pull request Feb 15, 2020

[7.x] [Remote clusters] Migrate client-side code out of legacy (#57365)…

f71a43d

… (#57747)

alisonelizabeth mentioned this pull request Feb 18, 2020

[Remote clusters] Fix regression with xpack.remote_clusters.ui.enabled setting #57895

Merged

alisonelizabeth mentioned this pull request Feb 28, 2020

[Remote clusters] add indexManagement as required plugin #58915

Merged

cjcenizal added the Feature:CCR and Remote Clusters label Apr 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Remote clusters] Migrate client-side code out of legacy #57365

[Remote clusters] Migrate client-side code out of legacy #57365

alisonelizabeth commented Feb 11, 2020 •

edited

Loading

elasticmachine commented Feb 11, 2020

alisonelizabeth Feb 13, 2020

jloleysens Feb 14, 2020

alisonelizabeth Feb 14, 2020

sebelga Feb 14, 2020

jloleysens Feb 14, 2020 •

edited

Loading

alisonelizabeth Feb 14, 2020 •

edited

Loading

jloleysens left a comment

jloleysens Feb 14, 2020

kibanamachine commented Feb 14, 2020

[Remote clusters] Migrate client-side code out of legacy #57365

[Remote clusters] Migrate client-side code out of legacy #57365

Conversation

alisonelizabeth commented Feb 11, 2020 • edited Loading

What's left

How to test

elasticmachine commented Feb 11, 2020

alisonelizabeth Feb 13, 2020

Choose a reason for hiding this comment

jloleysens Feb 14, 2020

Choose a reason for hiding this comment

alisonelizabeth Feb 14, 2020

Choose a reason for hiding this comment

sebelga Feb 14, 2020

Choose a reason for hiding this comment

jloleysens Feb 14, 2020 • edited Loading

Choose a reason for hiding this comment

alisonelizabeth Feb 14, 2020 • edited Loading

Choose a reason for hiding this comment

jloleysens left a comment

Choose a reason for hiding this comment

jloleysens Feb 14, 2020

Choose a reason for hiding this comment

kibanamachine commented Feb 14, 2020

💚 Build Succeeded

History

alisonelizabeth commented Feb 11, 2020 •

edited

Loading

jloleysens Feb 14, 2020 •

edited

Loading

alisonelizabeth Feb 14, 2020 •

edited

Loading