Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Fix typo on detection engine rule #56993

Merged
merged 2 commits into from
Feb 6, 2020
Merged

[SIEM] Fix typo on detection engine rule #56993

merged 2 commits into from
Feb 6, 2020

Conversation

rylnd
Copy link
Contributor

@rylnd rylnd commented Feb 6, 2020

Summary

This fixes a small typo that could result in both missed signals and false positive signals.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@rylnd rylnd added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 6, 2020
@rylnd rylnd self-assigned this Feb 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

FrankHassanabad
FrankHassanabad approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark-dufresne
Copy link

Is this going into the next 7.6 BC? Is it considered a blocker?

@MikePaquette
Copy link

Per discussion at SIEM team synch call earlier today:

  • It not a blocker.
  • It may be minor/safe enough to fold into the next 7.6 Build Candidate (if there is one) @tsg will make that call.
  • This change alone would not justify another BC build.

@tonymeehan
Copy link

In #mission-control this morning (10:30 EDT), it looks like we're considering another BC to pull in security fixes for node.js.

@randomuserid
Copy link
Contributor

Screen Shot 2020-02-06 at 11 16 58 AM

Search tests WAD

randomuserid
randomuserid approved these changes Feb 6, 2020
View reviewed changes
Copy link
Contributor

@randomuserid randomuserid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rylnd
Copy link
Contributor Author

rylnd commented Feb 6, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd merged commit 7e82cfb into elastic:master Feb 6, 2020
@rylnd rylnd deleted the fix_rule_typo branch February 6, 2020 20:54
This was referenced Feb 6, 2020
Merged
Merged
rylnd added a commit to rylnd/kibana that referenced this pull request Feb 6, 2020
@rylnd @elasticmachine
Fix typo on detection engine rule (elastic#56993)
d01d9f3 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rylnd added a commit that referenced this pull request Feb 6, 2020
@rylnd @elasticmachine
Fix typo on detection engine rule (#56993) (#57045)
6604f13 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rylnd added a commit that referenced this pull request Feb 6, 2020
@rylnd @elasticmachine
Fix typo on detection engine rule (#56993) (#57044)
8afc723 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 7, 2020
@jloleysens
Merge branch 'console/feature/text-objects-in-saved-objects' of githu…
9e266c6 
…b.com:jloleysens/kibana into console/feature/text-objects-in-saved-objects

* 'console/feature/text-objects-in-saved-objects' of github.com:jloleysens/kibana: (103 commits)
  fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998)
  TS of esKuery\node_types  (elastic#56857)
  Kibana app migration: Move static code dependencies into kibana_legacy plugin, part 1 (elastic#56408)
  Retry ES API calls that fail with 410/Gone (elastic#56950)
  [APM] Show missing permissions message to the user on the Services overview (elastic#56374)
  Fixing flaky CI tests for custom appRoutes (elastic#55763)
  [State Management][Docs] State syncing utils docs (elastic#56479)
  [Index management] Remove index mapper setting in tests (elastic#57066)
  Exposed common EuiExpressions to separate components be able to reuse for building new for Alert Types  (elastic#56466)
  [SIEM] update url state between page if date is relative (elastic#56813)
  fix for chart_types test (elastic#57056)
  chore(NA): remove compress from dll minimizer (elastic#57023)
  [File upload] Migrate routing to NP & add route validation (elastic#52313)
  Adding docs for grouped nav advanced setting (elastic#57013)
  Use i18n titles for field formatters, human names for numeral locales (elastic#56348)
  [Maps] Remove EMS catalogue url from docs (elastic#57020)
  [Endpoint] ERT-82 ERT-83 ERT-84: Alert list API with pagination (elastic#56538)
  [DOCS] Adds Apple notarization info to install doc (elastic#57042)
  [ML] New Platform server shim: update results service routes to use new platform router (elastic#56886)
  Fix typo on detection engine rule (elastic#56993)
  ...
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Feb 10, 2020
@rylnd @elasticmachine
Fix typo on detection engine rule (elastic#56993)
c1c4d66 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@randomuserid randomuserid randomuserid approved these changes

Assignees

@rylnd rylnd

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.6.1 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rylnd @elasticmachine @mark-dufresne @MikePaquette @tonymeehan @randomuserid @FrankHassanabad