Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with yarn 1.22.0 #56917

Merged
merged 3 commits into from
Feb 5, 2020
Merged

Fix compatibility with yarn 1.22.0 #56917

merged 3 commits into from
Feb 5, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Feb 5, 2020 •
edited
Loading

yarnpkg/yarn#7881 broke @kbn/pm, so we quick patched with #56914. Brian discovered that moving the --json flag ahead in the command makes it work, so I've reverted the hotfix, moved the flag up in our function, and improved the error handling a bit.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.6.0 v7.5.1 v6.8.6 labels Feb 5, 2020
@spalger spalger requested a review from a team as a code owner February 5, 2020 20:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger merged commit 12de6a8 into elastic:master Feb 5, 2020
spalger pushed a commit that referenced this pull request Feb 5, 2020
@spalger
Fix compatibility with yarn 1.22.0 (#56917)
ffdc180 
* Revert "force yarn 1.21.1 until we can handle invalid output of 1.22.0 (#56914)"

This reverts commit 5686010.

* move the --json argument before `workspaces` so it still works

* update kbn/pm dist

(cherry picked from commit 12de6a8)
spalger pushed a commit that referenced this pull request Feb 5, 2020
@spalger
Fix compatibility with yarn 1.22.0 (#56917)
a39524c 
* Revert "force yarn 1.21.1 until we can handle invalid output of 1.22.0 (#56914)"

This reverts commit 5686010.

* move the --json argument before `workspaces` so it still works

* update kbn/pm dist

(cherry picked from commit 12de6a8)
@spalger spalger removed the v6.8.6 label Feb 5, 2020
This was referenced Feb 5, 2020
Merged
Merged
spalger pushed a commit that referenced this pull request Feb 5, 2020
@spalger
Fix compatibility with yarn 1.22.0 (#56917)
44727d0 
* Revert "force yarn 1.21.1 until we can handle invalid output of 1.22.0 (#56914)"

This reverts commit 5686010.

* move the --json argument before `workspaces` so it still works

* update kbn/pm dist

(cherry picked from commit 12de6a8)
@spalger
Copy link
Contributor Author

spalger commented Feb 5, 2020

7.7/7.x: ffdc180
7.6: a39524c
7.5: 44727d0

@spalger spalger deleted the fix/yarn-1.22.0-compat branch February 5, 2020 21:24
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Feb 10, 2020
Fix compatibility with yarn 1.22.0 (elastic#56917)
238c23b 
* Revert "force yarn 1.21.1 until we can handle invalid output of 1.22.0 (elastic#56914)"

This reverts commit 5686010.

* move the --json argument before `workspaces` so it still works

* update kbn/pm dist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@brianseeders brianseeders brianseeders approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.5.1 v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spalger @elasticmachine @kibanamachine @tylersmalley @brianseeders