Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds the Kibana server uuid to eventLog events #56004

Merged
merged 3 commits into from
Jan 29, 2020

Conversation

pmuellr
Copy link
Member

@pmuellr pmuellr commented Jan 27, 2020

Summary

resolves #55631

Also beefed up the event_logger test cases.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

resolves elastic#55631

Also beefed up the event_logger test cases.
@pmuellr pmuellr added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jan 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@pmuellr
Copy link
Member Author

pmuellr commented Jan 27, 2020

@elasticmachine merge upstream

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! 👍

@YulNaumenko YulNaumenko self-requested a review January 28, 2020 17:41
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmmorris
Copy link
Contributor

LGTM, thanks for expanding these tests :)

@pmuellr
Copy link
Member Author

pmuellr commented Jan 29, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pmuellr pmuellr merged commit 90ad260 into elastic:master Jan 29, 2020
pmuellr added a commit to pmuellr/kibana that referenced this pull request Jan 29, 2020
resolves elastic#55631

Also beefed up the event_logger test cases.
pmuellr added a commit that referenced this pull request Jan 29, 2020
resolves #55631

Also beefed up the event_logger test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[alerting event log] add Kibana server uuid to all logged events
6 participants